Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "Unknown or generated". 13 files have unknown
     license. Detailed output of licensecheck:

MIT/X11 (BSD like)
------------------
libparserutils-0.1.2/include/parserutils/charset/codec.h
libparserutils-0.1.2/include/parserutils/charset/mibenum.h
libparserutils-0.1.2/include/parserutils/charset/utf16.h
libparserutils-0.1.2/include/parserutils/charset/utf8.h
libparserutils-0.1.2/include/parserutils/errors.h
libparserutils-0.1.2/include/parserutils/functypes.h
libparserutils-0.1.2/include/parserutils/input/inputstream.h
libparserutils-0.1.2/include/parserutils/parserutils.h
libparserutils-0.1.2/include/parserutils/types.h
libparserutils-0.1.2/include/parserutils/utils/buffer.h
libparserutils-0.1.2/include/parserutils/utils/stack.h
libparserutils-0.1.2/include/parserutils/utils/vector.h
libparserutils-0.1.2/src/charset/aliases.c
libparserutils-0.1.2/src/charset/aliases.h
libparserutils-0.1.2/src/charset/codec.c
libparserutils-0.1.2/src/charset/codecs/8859_tables.h
libparserutils-0.1.2/src/charset/codecs/codec_8859.c
libparserutils-0.1.2/src/charset/codecs/codec_ascii.c
libparserutils-0.1.2/src/charset/codecs/codec_ext8.c
libparserutils-0.1.2/src/charset/codecs/codec_impl.h
libparserutils-0.1.2/src/charset/codecs/codec_utf16.c
libparserutils-0.1.2/src/charset/codecs/codec_utf8.c
libparserutils-0.1.2/src/charset/codecs/ext8_tables.h
libparserutils-0.1.2/src/charset/encodings/utf16.c
libparserutils-0.1.2/src/charset/encodings/utf8.c
libparserutils-0.1.2/src/charset/encodings/utf8impl.h
libparserutils-0.1.2/src/input/filter.c
libparserutils-0.1.2/src/input/filter.h
libparserutils-0.1.2/src/input/inputstream.c
libparserutils-0.1.2/src/utils/buffer.c
libparserutils-0.1.2/src/utils/endian.h
libparserutils-0.1.2/src/utils/errors.c
libparserutils-0.1.2/src/utils/stack.c
libparserutils-0.1.2/src/utils/utils.h
libparserutils-0.1.2/src/utils/vector.c

Unknown or generated
--------------------
libparserutils-0.1.2/build/conv.pl
libparserutils-0.1.2/build/make-aliases.pl
libparserutils-0.1.2/test/aliases.c
libparserutils-0.1.2/test/cscodec-8859.c
libparserutils-0.1.2/test/cscodec-ext8.c
libparserutils-0.1.2/test/cscodec-utf16.c
libparserutils-0.1.2/test/cscodec-utf8.c
libparserutils-0.1.2/test/filter.c
libparserutils-0.1.2/test/inputstream.c
libparserutils-0.1.2/test/regression/filter-badenc-segv.c
libparserutils-0.1.2/test/regression/filter-segv.c
libparserutils-0.1.2/test/regression/stream-nomem.c
libparserutils-0.1.2/test/testutils.h

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     libparserutils-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: libparserutils-0.1.2-1.fc21.i686.rpm
          libparserutils-devel-0.1.2-1.fc21.i686.rpm
          libparserutils-doc-0.1.2-1.fc21.noarch.rpm
          libparserutils-0.1.2-1.fc21.src.rpm
libparserutils.i686: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
libparserutils.i686: W: spelling-error %description -l en_US parsers -> parser, parses, parers
libparserutils.i686: W: spelling-error %description -l en_US iconv -> icon, icons, icon v
libparserutils.i686: W: spelling-error %description -l en_US charset -> char set, char-set, catharses
libparserutils.i686: W: spelling-error %description -l en_US enum -> menu, en um, en-um
libparserutils.i686: W: spelling-error %description -l en_US endian -> Indian, Dianne, Diane
libparserutils.i686: W: spelling-error %description -l en_US resizeable -> realizable
libparserutils-devel.i686: W: no-documentation
libparserutils.src: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
libparserutils.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
libparserutils.src: W: spelling-error %description -l en_US iconv -> icon, icons, icon v
libparserutils.src: W: spelling-error %description -l en_US charset -> char set, char-set, catharses
libparserutils.src: W: spelling-error %description -l en_US enum -> menu, en um, en-um
libparserutils.src: W: spelling-error %description -l en_US endian -> Indian, Dianne, Diane
libparserutils.src: W: spelling-error %description -l en_US resizeable -> realizable

--->>> resizable ;)

4 packages and 0 specfiles checked; 0 errors, 15 warnings.



Rpmlint (installed packages)
----------------------------
# rpmlint libparserutils-doc libparserutils libparserutils-devel
libparserutils.i686: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
libparserutils.i686: W: spelling-error %description -l en_US parsers -> parser, parses, parers
libparserutils.i686: W: spelling-error %description -l en_US iconv -> icon, icons, icon v
libparserutils.i686: W: spelling-error %description -l en_US charset -> char set, char-set, catharses
libparserutils.i686: W: spelling-error %description -l en_US enum -> menu, en um, en-um
libparserutils.i686: W: spelling-error %description -l en_US endian -> Indian, Dianne, Diane
libparserutils.i686: W: spelling-error %description -l en_US resizeable -> realizable

--->>> resizable ;)

libparserutils-devel.i686: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'



Requires
--------
libparserutils-doc (rpmlib, GLIBC filtered):

libparserutils (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6
    rtld(GNU_HASH)

libparserutils-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libparserutils(x86-32)
    libparserutils.so.0



Provides
--------
libparserutils-doc:
    libparserutils-doc

libparserutils:
    libparserutils
    libparserutils(x86-32)
    libparserutils.so.0

libparserutils-devel:
    libparserutils-devel
    libparserutils-devel(x86-32)
    pkgconfig(libparserutils)



Source checksums
----------------
http://download.netsurf-browser.org/libs/releases/libparserutils-0.1.2-src.tar.gz :
  CHECKSUM(SHA256) this package     : 0a21efd3882c19965f57161c4ecda85a363a71dbe090030dfa69f9aecd2160aa
  CHECKSUM(SHA256) upstream package : 0a21efd3882c19965f57161c4ecda85a363a71dbe090030dfa69f9aecd2160aa


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn libparserutils-0.1.2-1.fc20.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG

----------------
Fix the %description of sizable.

PACKAGE APPROVED.

New Package SCM Request
=======================
Package Name: libparserutils
Short Description: A library for building efficient parsers
Owners: dtardon caolanm
Branches: 
InitialCC:

Git done (by process-git-requests).

(In reply to Christopher Meng from comment #1)
> [x]: Useful -debuginfo package or justification otherwise.

Again, it's not useful nor is there justification otherwise -- this package is not built with $RPM_OPT_FLAGS and looks like rpmlint was not run on the debuginfo package as it would have flagged the error. One way to fix it:

-make %{?_smp_mflags} %{make_vars}
+CFLAGS="$RPM_OPT_FLAGS" make %{?_smp_mflags} %{make_vars}

Package Change Request
======================
Package Name: libparserutils
New Branches: f20
Owners: dtardon caolanm cicku

Git done (by process-git-requests).

libparserutils-0.2.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libparserutils-0.2.0-2.fc20

libparserutils-0.2.0-2.fc20 has been pushed to the Fedora 20 stable repository.