Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.4.3-1.fc19.src.rpm

- update to 1.4.3

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-1.fc19.src.rpm

- update to 1.5.0

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-1.fc20.src.rpm

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-2.fc20.src.rpm

- avoid missing dep (Hadoop) on arm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues
======
- doc directory contains images from some research paper that might be copyrighted,
  it needs to be removed (from the SRPM to be sure)
- There are some executable tools in parquet-tools module, they should have launcher
  scripts installed (preferably generated by %jpackage_script)
- Name repeated in summary (rpmlint W: name-repeated-in-summary)


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)".
     19 files have unknown license. Detailed output of licensecheck in
     /home/msimacek/reviews/review-parquet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-poms/parquet
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-poms/parquet
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It is
     pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in parquet-
     javadoc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: parquet-1.5.0-1.fc22.noarch.rpm
          parquet-javadoc-1.5.0-1.fc22.noarch.rpm
          parquet-1.5.0-1.fc22.src.rpm
parquet.noarch: W: name-repeated-in-summary C Parquet
parquet.src: W: name-repeated-in-summary C Parquet
3 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
parquet-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

parquet (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(com.google.guava:guava)
    mvn(com.twitter:parquet-format)
    mvn(commons-cli:commons-cli)
    mvn(commons-codec:commons-codec)
    mvn(it.unimi.dsi:fastutil)
    mvn(org.apache.avro:avro)
    mvn(org.codehaus.jackson:jackson-core-asl)
    mvn(org.codehaus.jackson:jackson-mapper-asl)
    mvn(org.xerial.snappy:snappy-java)



Provides
--------
parquet-javadoc:
    parquet-javadoc

parquet:
    mvn(com.twitter:parquet-avro)
    mvn(com.twitter:parquet-avro:pom:)
    mvn(com.twitter:parquet-column)
    mvn(com.twitter:parquet-column:pom:)
    mvn(com.twitter:parquet-common)
    mvn(com.twitter:parquet-common:pom:)
    mvn(com.twitter:parquet-encoding)
    mvn(com.twitter:parquet-encoding:pom:)
    mvn(com.twitter:parquet-generator)
    mvn(com.twitter:parquet-generator:pom:)
    mvn(com.twitter:parquet-hadoop)
    mvn(com.twitter:parquet-hadoop:pom:)
    mvn(com.twitter:parquet-tools)
    mvn(com.twitter:parquet-tools:pom:)
    mvn(com.twitter:parquet:pom:)
    parquet



Source checksums
----------------
https://github.com/Parquet/parquet-mr/archive/parquet-1.5.0.tar.gz :
  CHECKSUM(SHA256) this package     : e41585703ef8ffd67703da5d5c5b624a423ecd5c1158ecef1cb6bfce635636a7
  CHECKSUM(SHA256) upstream package : e41585703ef8ffd67703da5d5c5b624a423ecd5c1158ecef1cb6bfce635636a7


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -n parquet
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-3.fc20.src.rpm

- fix summary
- remove images with unknow copyright

for this i prefer wait until have available all buildable sub-modules
- There are some executable tools in parquet-tools module, they should have launcher
  scripts installed (preferably generated by %jpackage_script)

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-3.fc20.src.rpm

added parquet-tools launcher script

parquet-tools -h
usage: parquet-tools cat [option...] <input>
where option is one of:
       --debug     Disable color output even if supported
    -h,--help      Show this help string
       --no-color  Disable color output even if supported
where <input> is the parquet file to print to stdout

usage: parquet-tools head [option...] <input>
where option is one of:
       --debug          Disable color output even if supported
    -h,--help           Show this help string
    -n,--records <arg>  The number of records to show (default: 5)
       --no-color       Disable color output even if supported
where <input> is the parquet file to print to stdout

usage: parquet-tools schema [option...] <input>
where option is one of:
    -d,--detailed <arg>  Show detailed information about the schema.
       --debug           Disable color output even if supported
    -h,--help            Show this help string
       --no-color        Disable color output even if supported
where <input> is the parquet file containing the schema to show

usage: parquet-tools meta [option...] <input>
where option is one of:
       --debug     Disable color output even if supported
    -h,--help      Show this help string
       --no-color  Disable color output even if supported
where <input> is the parquet file to print to stdout

usage: parquet-tools dump [option...] <input>
where option is one of:
    -c,--column <arg>  Dump only the given column, can be specified more than
                       once
    -d,--disable-data  Do not dump column data
       --debug         Disable color output even if supported
    -h,--help          Show this help string
    -m,--disable-meta  Do not dump row group and page metadata
       --no-color      Disable color output even if supported
where <input> is the parquet file to print to stdout

Spec URL: http://gil.fedorapeople.org/parquet.spec
SRPM URL: http://gil.fedorapeople.org/parquet-1.5.0-4.fc20.src.rpm

- add parquet-tools sub package

can we terminate?

yes, I was waiting for the dependent package. APPROVED

Thanks!

New Package SCM Request
=======================
Package Name: parquet
Short Description: Java readers/writers for columnar file formats to use with Map-Reduce
Upstream URL: http://parquet.io/
Owners: gil
Branches: f21 f22
InitialCC: java-sig

Git done (by process-git-requests).

parquet-1.5.0-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/parquet-1.5.0-4.fc21

parquet-1.5.0-4.fc21 has been pushed to the Fedora 21 testing repository.

parquet-1.5.0-4.fc21 has been pushed to the Fedora 21 stable repository.

parquet-1.5.0-4.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/parquet-1.5.0-4.fc22

parquet-1.5.0-4.fc22 has been pushed to the Fedora 22 stable repository.