Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1079635 - Use system libedit instead of bundled one
Summary: Use system libedit instead of bundled one
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: OpenIPMI
Version: 22
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Boris Ranto
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DuplicSysLibsTracker 1075696
TreeView+ depends on / blocked
 
Reported: 2014-03-22 11:15 UTC by Ville Skyttä
Modified: 2015-11-24 20:33 UTC (History)
2 users (show)

Fixed In Version: OpenIPMI-2.0.21-4.fc22.src.rpm
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-24 20:33:25 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Use system libedit instead of bundled one (47.39 KB, patch)
2014-03-22 11:15 UTC, Ville Skyttä 		no flags Details | Diff
View All

Description Ville Skyttä 2014-03-22 11:15:11 UTC 
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries

'git am'able fix attached, build tested only. Let me know if you'd
like me to push and build this for devel. Also contains the following
"while at it" fixes:

- Drop no longer needed aarch64 hacks
- Package all installed files (#1075696)
- Don't ship lanserv files in main package
Comment 1 Ville Skyttä 2014-03-22 11:15:16 UTC 
Created attachment 877575 [details]
Use system libedit instead of bundled one

- Drop no longer needed aarch64 hacks
- Package all installed files (#1075696)
- Don't ship lanserv files in main package
Comment 2 Ales Ledvinka 2014-08-12 12:46:06 UTC 
Could you please elaborate why is the patch dropping the aarch64 and lanserv.

Fixed the library duplication.
Comment 3 Ville Skyttä 2014-08-14 08:21:02 UTC 
(In reply to Ales Ledvinka from comment #2)
> Could you please elaborate why is the patch dropping the aarch64 and lanserv.

It is not dropping aarch64 and lanserv. As noted in the initial comment:

"Drop no longer needed aarch64 hacks" -- it is dropping a hack that is no longer needed, it is automatically handled by the %configure macro. More details in bug 951442.

"Don't ship lanserv files in main package" -- lanserv files are already included in the -lanserv subpackage, no need to include them in the main package as well.

Regarding the libedit changes made, "Requires: libedit" is superfluous and should be removed, it's taken care of by an automatic dependency on the actual lib.
Comment 4 Jaroslav Reznik 2015-03-03 16:59:54 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Comment 5 Fedora Admin XMLRPC Client 2015-11-05 08:31:02 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 6 Fedora Admin XMLRPC Client 2015-11-05 10:13:28 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 7 Boris Ranto 2015-11-24 20:33:25 UTC 
I removed the duplicate files in the file lists. However, we need to run the autotools bits in order to generate the new configure script as we removed the libedit directory and the configure script would fail otherwise. I have updated the comments regarding this accordingly.
Note You need to log in before you can comment on or make changes to this bug.