Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1086447 (kf5-filesystem, kf5-rpmmacros) - Review Request: kf5 - Filesystem ownership and RPM macros for KF5 packages
Summary: Review Request: kf5 - Filesystem ownership and RPM macros for KF5 packages
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-filesystem, kf5-rpmmacros
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-04-10 23:13 UTC by Daniel Vrátil
Modified: 2015-11-02 01:37 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-22 14:23:31 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-04-10 23:13:22 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem-4.98.0-2.src.rpm
Description: This package provides macros.kf5 with RPM macros to be used in all KDE Frameworks packages and also owns some of the directories defined by the macros
Fedora Account System Username: dvratil
Comment 1 Christopher Meng 2014-04-11 00:46:41 UTC 
1. %define framework filesystem

Use %global.

2. cp %{_sourcedir}/macros.kf5 %{buildroot}%{_rpmconfigdir}/macros.d

I prefer using install -pm644 as it can notly set the permission but also can preserve the timestamp.
Comment 2 Christopher Meng 2014-04-11 01:51:24 UTC 
Are you sure it can be built successfully? I first saw the SPEC then came up with this question, followed by mock output:

Processing files: kf5-filesystem-4.98.0-2.noarch
RPM build errors:
error: File must begin with "/": %{_kf5_includedir}
error: File must begin with "/": %{_kf5_plugindir}
error: File must begin with "/": %{_kf5_datadir}
    File must begin with "/": %{_kf5_includedir}
    File must begin with "/": %{_kf5_plugindir}
    File must begin with "/": %{_kf5_datadir}
Comment 3 Daniel Vrátil 2014-04-11 09:27:46 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-filesystem-4.98.0-3.src.rpm

Replaced %define by %global and cp by install, fixed build (I had the macros.kf5 file already installed, so it didn't fail for me, sorry for that)
Comment 4 Christopher Meng 2014-04-16 02:22:36 UTC 
PACKAGE APPROVED.
Comment 5 Daniel Vrátil 2014-04-16 12:47:43 UTC 
It was decided on last KDE SIG meeting that we want to split the package to kf5-filesystem and kf5-rpmmacros (and eventually add kf5-settings if we decide we need it in future), so I renamed the base package to "kf5" and updated the request accordingly.

Nothing much has changed, but I'd like to ask you for a new review anyway. Thanks and sorry for the trouble :-)

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm
Comment 6 Christopher Meng 2014-04-16 15:48:16 UTC 
Should be kf5-rpm-macros. Isn't it?
Comment 7 Daniel Vrátil 2014-04-18 07:56:42 UTC 
Good point. I just updated the specfile, didn't bump Release.

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-4.98.0-4.src.rpm
Comment 8 Christopher Meng 2014-04-20 04:16:25 UTC 
Add missing dots at the end of the %description.

Others are perfect.
Comment 9 Daniel Vrátil 2014-04-22 09:48:25 UTC 
New Package SCM Request
=======================
Package Name: kf5
Short Description: Filesystem ownership and RPM macros for KDE Frameworks 5 packages
Owners: dvratil
Branches: 
InitialCC: rdieter jgrulich ltinkl kkofler
Comment 10 Gwyn Ciesla 2014-04-22 13:03:23 UTC 
Git done (by process-git-requests).
Comment 11 Daniel Vrátil 2014-04-22 14:23:31 UTC 
Package pushed and built in Koji for rawhide/F21: 

http://koji.fedoraproject.org/koji/taskinfo?taskID=6764931
Comment 12 Rex Dieter 2014-07-19 18:20:38 UTC 
Package Change Request
======================
Package Name: kf5
New Branches: f20
Owners: dvratil rdieter jgrulich ltinkl kkofler
Comment 13 Gwyn Ciesla 2014-07-21 12:44:45 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.