Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1086448 (kf5-attica) - Review Request: kf5-attica - KDE Frameworks Tier 1 Addon with implementation of the Open Collaboration Services API
Summary: Review Request: kf5-attica - KDE Frameworks Tier 1 Addon with implementation ...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-attica
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-04-10 23:19 UTC by Daniel Vrátil
Modified: 2015-11-02 01:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-19 09:05:31 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-04-10 23:19:17 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-1.fc20.src.rpm
Description: Attica is a Tier 1 KDE Framework that implements the Open Collaboration Services API version 1.4.
Fedora Account System Username: dvratil

This is the very first of Tier 1 Frameworks. I'll update all the other Frameworks specfiles based on this review, so that we can do it all in as few rounds as possible.
Comment 1 Jan Grulich 2014-04-22 14:45:56 UTC 
1) Obsoletes and Provides should be versioned, see [1]
2) Rpmlint says that summary is too long, so it should be probably shorter

[1] - https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Comment 2 Daniel Vrátil 2014-05-05 09:21:44 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-attica-4.98.0-2.fc20.src.rpm

- shortened summary a bit
- removed Provides, Obsoletes - they were introduced in kde-frameworks Copr repo, but are not needed in Fedora
Comment 3 Jan Grulich 2014-05-05 09:32:13 UTC 
Approved, now it looks okay to me.
Comment 4 Daniel Vrátil 2014-05-05 12:58:06 UTC 
New Package SCM Request
=======================
Package Name: kf5-attica
Short Description: KDE Frameworks Tier 1 Addon with Open Collaboration Services API
Owners: dvratil ltinkl rdieter kkofler jgrulich
Branches:
InitialCC:
Comment 5 Gwyn Ciesla 2014-05-05 13:10:31 UTC 
Git done (by process-git-requests).
Comment 6 Daniel Vrátil 2014-09-25 08:38:25 UTC 
Package Change Request
=======================
Package Name: 
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 7 Daniel Vrátil 2014-09-25 08:44:42 UTC 
Package Change Request
=======================
Package Name: kf5-attica
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 8 Gwyn Ciesla 2014-09-25 12:12:59 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.