Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1091479 (pam-kwallet) - Review Request: pam-kwallet - PAM module for KWallet
Summary: Review Request: pam-kwallet - PAM module for KWallet
Keywords:
Status: CLOSED ERRATA
Alias: pam-kwallet
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews F21Target-kde
TreeView+ depends on / blocked
 
Reported: 2014-04-25 17:04 UTC by Rex Dieter
Modified: 2014-09-11 13:32 UTC (History)
4 users (show)

Fixed In Version: pam-kwallet-0-0.3.20140428gitaf786456.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-01 14:16:27 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2014-04-25 17:04:59 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet-0-0.1.20140409git7604d424.fc20.src.rpm
Description: PAM module for kwallet
Fedora Account System Username: rdieter

This is the KDE/kwallet equivalent to gnome-keyring-pam
Comment 1 Rex Dieter 2014-04-28 23:13:34 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet-0-0.2.20140428gitaf786456.fc20.src.rpm

%changelog
* Mon Apr 28 2014 Rex Dieter <rdieter> 0-0.2.20140428gitaf786456
- 20140428 git snapshot
Comment 2 Jan Grulich 2014-04-30 08:51:04 UTC 
1) License should be LGPLv2+
2) rpmlint says:
pam-kwallet.i686: E: missing-call-to-setgroups /lib/security/pam_kwallet.so

I was Googling it and it seems that pam_kwallet should call setgroup before using setuid/setgid. I was also talking with Alex Fieastas and he is rather busy, so I'll try to provide a patch for that.
Comment 3 Rex Dieter 2014-04-30 11:58:04 UTC 
Spec URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/pam-kwallet/pam-kwallet-0-0.3.20140428gitaf786456.fc20.src.rpm

%changelog
* Wed Apr 30 2014 Rex Dieter <rdieter> 0-0.3.20140428gitaf786456
- License: LGPLv2+

(imo, we can fix the setgroups thing post-review)
Comment 4 Jan Grulich 2014-04-30 12:02:29 UTC 
That's true, at least it's not something what could be fixed on our side. Except the setgroups thing the package looks good.
Comment 5 Rex Dieter 2014-05-01 13:05:37 UTC 
New Package SCM Request
=======================
Package Name: pam-kwallet
Short Description: PAM module for KWallet
Owners: rdieter
Branches: f20
InitialCC:
Comment 6 Gwyn Ciesla 2014-05-01 13:47:59 UTC 
Git done (by process-git-requests).
Comment 7 Rex Dieter 2014-05-01 14:16:27 UTC 
imported, thanks.

comps updated, pam configs updates submitted for kde-settings(kdm), lightdm, sddm so far.  will hit others (like gdm) soon.
Comment 8 Fedora Update System 2014-07-14 13:06:54 UTC 
pam-kwallet-0-0.3.20140428gitaf786456.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/pam-kwallet-0-0.3.20140428gitaf786456.fc20
Comment 9 Fedora Update System 2014-07-25 10:04:08 UTC 
pam-kwallet-0-0.3.20140428gitaf786456.fc20 has been pushed to the Fedora 20 stable repository.
Comment 10 Wei-Lun Chao 2014-09-11 09:18:15 UTC 
Would pam_kwallet be a better package name?
Comment 11 Rex Dieter 2014-09-11 13:32:30 UTC 
Maybe a little, but I don't think that's significant enough to warrant renaming things now.
Note You need to log in before you can comment on or make changes to this bug.