Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1094325 (kf5-kconfig) - Review Request: kf5-kconfig - KDE Frameworks 5 Tier 1 addon with advanced configuration system
Summary: Review Request: kf5-kconfig - KDE Frameworks 5 Tier 1 addon with advanced con...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kconfig
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-05-05 13:09 UTC by Daniel Vrátil
Modified: 2015-11-02 01:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-21 12:39:06 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-05-05 13:09:52 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig-4.99.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 1 addon with advanced configuration system made of two parts: KConfigCore and KConfigGui.
Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2014-05-06 15:28:52 UTC 
Doesn't build, because it cannot find /usr/libexec/kf5/kconf_update, because this file is installed to /usr/lib64/libexec/kf5/kconf_update.
Comment 2 Daniel Vrátil 2014-05-13 08:27:55 UTC 
Sorry, I forgot to update kf5-rpm-macros in rawhide. Please try again against kf5-rpm-macros-4.99.0-3 (should be available in rawhide now, or from our Copr)
Comment 3 Jan Grulich 2014-05-19 09:31:08 UTC 
1) License should be GPLv2+ and LGPLv2+ and MIT/X11
2) Too long description
3) Missing ldconfig call in postin/postun for subpackages
4) kf5-kconfig should be noarch - http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary
Comment 4 Daniel Vrátil 2014-05-20 11:54:13 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kconfig-4.99.0-2.fc20.src.rpm

Fixed 1, 2 and 3.

Ad 4): kf5-kconfig requires kf5-kconfig-core%{?_isa}, so there's difference between installing kf5-kconfig.i686 and kf5-kconfig.x86_64 which is right IMO. If kf5-kconfig would be noarch, then you wouldn't be able to use it to install all subpackages for non-native arch. Also it seems that if you make base package noarch, then all subpackages must be noarch, which is not the case here howerver, so this cannot be implemented.
Comment 5 Jan Grulich 2014-05-20 14:52:31 UTC 
1) MIT/X11 should be just MIT, sorry my mistake
2) rpmlint is still complaining about too long line in description for base package
3) ok
4) you are probably right, I didn't realize that kf5-kconfig is something like metapackage.

Issues above can be fixed during import, approved.
Comment 6 Daniel Vrátil 2014-05-21 08:01:19 UTC 
New Package SCM Request
=======================
Package Name: kf5-kconfig
Short Description: KDE Frameworks 5 Tier 1 addon with advanced configuration system
Upstream URL: http://www.kde.org
Owners: dvratil rdieter kkofler ltinkl jgrulich
Branches: 
InitialCC:
Comment 7 Gwyn Ciesla 2014-05-21 10:10:41 UTC 
Git done (by process-git-requests).
Comment 8 Daniel Vrátil 2014-09-25 08:38:54 UTC 
Package Change Request
=======================
Package Name: 
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 9 Daniel Vrátil 2014-09-25 08:47:44 UTC 
Package Change Request
=======================
Package Name: kf5-kconfig
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 10 Gwyn Ciesla 2014-09-25 12:16:04 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.