Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1096013 - jboss-dmr: migrate to maven-processor-plugin
Summary: jboss-dmr: migrate to maven-processor-plugin
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: jboss-dmr
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1096007
Blocks: 1096012 1106864 1181081
TreeView+ depends on / blocked
 
Reported: 2014-05-09 05:26 UTC by Michal Srb
Modified: 2016-09-12 12:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-12 12:30:18 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
WIP patch (3.38 KB, patch)
2015-03-22 18:50 UTC, Marek Goldmann 		no flags Details | Diff
View All

Description Michal Srb 2014-05-09 05:26:19 UTC 
Description of problem:

jboss-dmr uses apt-maven-plugin for processing annotations at build time. Since apt is no longer available in JDK8, this package should use maven-processor-plugin instead.
Comment 1 Jaroslav Reznik 2015-03-03 17:01:12 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Comment 2 Marek Goldmann 2015-03-22 18:14:46 UTC 
Michal, any update on this?
Comment 3 Marek Goldmann 2015-03-22 18:50:39 UTC 
Created attachment 1005076 [details]
WIP patch

Michal, you could reuse the attached patch to make it work. In the current state of this patch the build throws:

[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ jboss-dmr ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 23 source files to /builddir/build/BUILD/jboss-dmr-1.2.0.Final/target/classes
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Skipping JBoss Dynamic Model Representation
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.715 s
[INFO] Finished at: 2015-03-22T19:25:14+01:00
[INFO] Final Memory: 21M/185M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project jboss-dmr: Fatal error compiling: java.lang.IllegalArgumentException: The generated class cannot be a nested class. -> [Help 1]
DEBUG: Child return code was: 1
INFO: EXCEPTION: Command failed. See logs for output.
Comment 4 Michal Srb 2015-03-23 06:16:13 UTC 
(In reply to Marek Goldmann from comment #2)
> Michal, any update on this?

Hi Marek,

This turned out to be much more trickier than I initially thought. And I am not sure whether it makes sense to spend more time on it. Given the fact that cookcc upstream is pretty much inactive [1], and jboss-dmr upstream still building with JDK < 8 (as they apparently haven't hit the issue yet), I would say that using pre-generated sources could be a good trade-off for Fedora's jboss-dmr package.
What do you think?

[1]: https://code.google.com/p/cookcc/issues/detail?id=21
Comment 5 Michal Srb 2015-04-29 18:17:54 UTC 
The package now builds with JDK8, but proper fix is still missing. This bug should probably stay open, but I am moving it back to NEW, since I don't plan to work on it anytime soon.
Comment 6 gil cattaneo 2015-08-12 13:29:29 UTC 
latest cookcc (0.4) should work with Java8.
available @ https://github.com/coconut2015/cookcc
Comment 7 gil cattaneo 2016-07-03 15:14:47 UTC 
Is available  a patch for remove cookcc and add Java8 support @
https://github.com/jbossas/jboss-dmr/pull/20
Comment 8 gil cattaneo 2016-07-25 15:14:22 UTC 
is available a pre-release which dont use anymore cookcc
referencies https://github.com/jbossas/jboss-dmr/pull/20
Comment 9 gil cattaneo 2016-08-29 16:40:19 UTC 
Available https://github.com/jbossas/jboss-dmr/releases/tag/1.4.0.Beta1
Comment 10 gil cattaneo 2016-09-12 12:27:07 UTC 
Next Wildfly release should use jboss-drm-1.4.0.Beta1
Close this bug
Note You need to log in before you can comment on or make changes to this bug.