Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1100926 (php-guzzlehttp-streams) - Review Request: php-guzzlehttp-streams - Provides a simple abstraction over streams of data
Summary: Review Request: php-guzzlehttp-streams - Provides a simple abstraction over s...
Keywords:
Status: CLOSED ERRATA
Alias: php-guzzlehttp-streams
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: php-guzzlehttp-guzzle
TreeView+ depends on / blocked
 
Reported: 2014-05-23 23:50 UTC by Shawn Iwinski
Modified: 2014-06-18 22:23 UTC (History)
2 users (show)

Fixed In Version: php-guzzlehttp-streams-1.1.0-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-18 22:23:56 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (6.99 KB, text/x-log)
2014-06-02 08:59 UTC, Remi Collet
no flags Details
review.txt (6.96 KB, text/plain)
2014-06-02 08:59 UTC, Remi Collet
no flags Details

Description Shawn Iwinski 2014-05-23 23:50:23 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/c2961eb3ab85d30987f730dca821594a25d8e2e2/php-guzzlehttp-streams.spec

SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-streams-1.1.0-1.fc20.src.rpm

Description:
Provides a simple abstraction over streams of data.

This library is used in Guzzle and is an implementation of the proposed
PSR-7 stream interface [1].

[1] https://github.com/php-fig/fig-standards/blob/master/proposed/http-message.md#34-psrhttpstreaminterface


Fedora Account System Username: siwinski

Comment 1 Remi Collet 2014-06-02 08:59:12 UTC
Created attachment 901382 [details]
phpci.log

Comment 2 Remi Collet 2014-06-02 08:59:36 UTC
Created attachment 901383 [details]
review.txt

Comment 3 Remi Collet 2014-06-02 09:01:23 UTC
[x]: Package is named according to the Package Naming Guidelines.
  Match php-vendor-lib

[x]: URL: https://github.com/guzzle/http
  Could use http://guzzlephp.org/ (from composer.json homepage)
  Both are fine for me.

[x]: Rpmlint is run on all installed packages.
  Could drop the anchor from the link.



No blockers.

== APPROVED ==

Comment 4 Shawn Iwinski 2014-06-05 20:03:50 UTC
THANKS for the review!


New Package SCM Request
=======================
Package Name: php-guzzlehttp-streams
Short Description: Provides a simple abstraction over streams of data
Upstream URL: https://github.com/guzzle/streams
Owners: siwinski
Branches: f20 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-06-06 12:15:13 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-06-06 23:18:03 UTC
php-guzzlehttp-streams-1.1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-guzzlehttp-streams-1.1.0-2.fc20

Comment 7 Fedora Update System 2014-06-10 03:11:15 UTC
php-guzzlehttp-streams-1.1.0-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 8 Fedora Update System 2014-06-18 22:23:56 UTC
php-guzzlehttp-streams-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.