Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1105550 - Review Request: kf5-kdoctools - KDE Frameworks 5 Tier 2 addon for documentation
Summary: Review Request: kf5-kdoctools - KDE Frameworks 5 Tier 2 addon for documentation
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5 1113070
TreeView+ depends on / blocked
 
Reported: 2014-06-06 11:39 UTC by Daniel Vrátil
Modified: 2016-08-14 16:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-12 12:30:25 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-06-06 11:39:44 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools-4.100.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 2 addon for documentation
Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2014-06-11 14:21:34 UTC 
1) License should be LGPLv2+ and MIT

2) E: standard-dir-owned-by-package /usr/share/man/man[1,7,8]
- you should probably use %{_mandir}/man1/ and similar for man7 and man8

3) E: incorrect-fsf-address /usr/share/doc/HTML/*/kdoctools5-common/kde-localised.css
- this is not a blocking issue and upstream already know about it
Comment 2 Daniel Vrátil 2014-06-11 14:47:03 UTC 
Fixed license
Fixed man pages installation

Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdoctools-4.100.0-2.fc20.src.rpm
Comment 3 Jan Grulich 2014-06-11 15:02:13 UTC 
Looks good now, approved.
Comment 4 Daniel Vrátil 2014-06-11 15:04:11 UTC 
New Package SCM Request
=======================
Package Name: kf5-kdoctools
Short Description: KDE Frameworks 5 Tier 2 addon for generating documentation
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler
Branches: 
InitialCC:
Comment 5 Gwyn Ciesla 2014-06-11 21:08:00 UTC 
Git done (by process-git-requests).
Comment 6 Michael Schwendt 2014-06-25 12:01:52 UTC 
> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

Why? No shared libs are included in runtime linker's search path.


Which packages provide the following directories?

  /usr/include/KF5/XsltKde
  /usr/include/KF5
  /usr/share/kf5
  /usr/share/kf5/kdoctools

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership


> %package        doc

> /usr/share/doc/HTML/af/kdoctools5-common

It seems the package ought to require "kd5-filesystem" for these directories.
Comment 7 Daniel Vrátil 2014-06-25 13:57:15 UTC 
Thanks for spotting these!

Fixed in kf5-kdoctools-4.100.0-3
 - removed %post and %postun ldconfig as there are no shared libs
 - fixed directory ownership
 - -doc subpackges Requires kf5-filesystem
Comment 8 Daniel Vrátil 2014-09-25 08:59:20 UTC 
Package Change Request
=======================
Package Name: kf5-kdoctools
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 9 Gwyn Ciesla 2014-09-25 12:45:29 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.