Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1106364 - Review Request: perl-MooX-Types-MooseLike-Numeric - Moo types for numbers
Summary: Review Request: perl-MooX-Types-MooseLike-Numeric - Moo types for numbers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1105958
TreeView+ depends on / blocked
 
Reported: 2014-06-09 07:39 UTC by Ralf Corsepius
Modified: 2014-06-29 02:53 UTC (History)
2 users (show)

Fixed In Version: perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-29 02:53:39 UTC
Type: ---
Embargoed:
psabata: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Ralf Corsepius 2014-06-09 07:39:51 UTC 
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric-1.02-1.fc21.src.rpm
Description: Moo types for numbers
Fedora Account System Username: corsepiu

This package is a new mandatory requirement of newer versions of perl-CHI.
Comment 1 Petr Šabata 2014-06-17 09:06:25 UTC 
Taking the review.
Comment 2 Petr Šabata 2014-06-17 09:13:22 UTC 
The %description could definitely use some improvements -- at least capitalize the first word and end it with a fullstop.

Other suggestions, as usually:
BR perl
s/PERL_INSTALL_ROOT/DESTDIR/

The rest is fine.
Comment 3 Ralf Corsepius 2014-06-18 09:23:29 UTC 
Updated package:

Spec URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-MooX-Types-MooseLike-Numeric-1.02-2.fc21.src.rpm
Comment 4 Petr Šabata 2014-06-19 11:35:58 UTC 
Ack.
Comment 5 Ralf Corsepius 2014-06-19 14:40:51 UTC 
Thanks for the review, Petr.

New Package SCM Request
=======================
Package Name: perl-MooX-Types-MooseLike-Numeric
Short Description: Moo types for numbers
Upstream URL: http://search.cpan.org/dist/MooX-Types-MooseLike-Numeric/
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig
Comment 6 Kevin Fenzi 2014-06-19 20:55:45 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2014-06-20 08:07:53 UTC 
perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19
Comment 8 Fedora Update System 2014-06-21 02:57:33 UTC 
perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been pushed to the Fedora 19 testing repository.
Comment 9 Fedora Update System 2014-06-29 02:53:39 UTC 
perl-MooX-Types-MooseLike-Numeric-1.02-2.fc19 has been pushed to the Fedora 19 stable repository.
Note You need to log in before you can comment on or make changes to this bug.