Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1111979 (kf5-kapidox) - Review Request: kf5-kapidox - KDE Frameworks 5 Tier 4 module with scripts and data for building API documentation
Summary: Review Request: kf5-kapidox - KDE Frameworks 5 Tier 4 module with scripts and...
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kapidox
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-06-22 13:16 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-07 13:06:04 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2014-06-22 13:16:28 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox-4.100.0-1.fc20.src.rpm
Description: KDE Frameworks 5 Tier 4 module with scripts and data for building API documentation
Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2014-07-07 11:19:27 UTC 
1) License should be probably only BSD, also your license field is not in correct format
2) Summary is too long
3) /usr/lib/python2.7/site-packages/kapidox/depdiagram/generate.py should be executable
4) Package should be probably noarch because it doesn't contain any binaries
5) Missing license file in %doc
Comment 2 Jan Grulich 2014-07-07 11:20:02 UTC 
6) BR should be python2-devel instead of python-devel
Comment 3 Daniel Vrátil 2014-07-07 12:40:55 UTC 
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kapidox-4.100.0-2.fc20.src.rpm

- Fixed license
- Fixed summary
- Fixed BR
- Fixed missing license
- Made package noarch

I don't think that generate.py should be executable. site-packages are like plugins, they are afaik loaded by running sripts and cannot be executed stand-alone. I also checked other site-packages in /usr/lib/python2.7 and none of them is executable either.
Comment 4 Jan Grulich 2014-07-07 12:46:27 UTC 
Looks good now, approved.
Comment 5 Daniel Vrátil 2014-07-07 12:49:09 UTC 
New Package SCM Request
=======================
Package Name: kf5-kapidox
Short Description: KDE Frameworks 5 Tier 4 scripts and data for building API documentation
Upstream URL: http://www.kde.org
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Branches: 
InitialCC:
Comment 6 Gwyn Ciesla 2014-07-07 12:54:43 UTC 
Git done (by process-git-requests).
Comment 7 Daniel Vrátil 2014-09-25 09:06:08 UTC 
Package Change Request
=======================
Package Name: kf5-kapidox
New Branches: f20
Owners: dvratil ltinkl jgrulich kkofler rdieter than
Comment 8 Gwyn Ciesla 2014-09-25 13:15:39 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.