1115554 – Review Request: rubygem-shoulda-matchers - Making tests easy on the fingers and eyes

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1115554 - Review Request: rubygem-shoulda-matchers - Making tests easy on the fingers and eyes

Summary: Review Request: rubygem-shoulda-matchers - Making tests easy on the fingers a...

Keywords:
Status:	CLOSED RAWHIDE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Josef Stribny
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:	1115491
Blocks:	1060172
TreeView+	depends on / blocked

Reported:	2014-07-02 15:25 UTC by Vít Ondruch
Modified:	2016-01-04 05:53 UTC (History)
CC List:	3 users (show)
Fixed In Version:	rubygem-shoulda-matchers-2.6.1-3.fc21
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2014-07-07 11:45:39 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	jstribny: fedora-review+ gwync: fedora-cvs+

Attachments	(Terms of Use)

Description Vít Ondruch 2014-07-02 15:25:47 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-1.fc21.src.rpm
Description:
shoulda-matchers provides Test::Unit- and RSpec-compatible one-liners that
test common Rails functionality. These tests would otherwise be much longer,
more complex, and error-prone.
Fedora Account System Username: vondruch

Comment 1 Josef Stribny 2014-07-03 07:06:42 UTC

* Change upstream URL to git repo (ideally), http://thoughtbot.com/community/ is just a redirect.

* This should be probably filled to upstream (and I realize now its the same thing for shoulda-context):

# Fix wrong-file-end-of-line-encoding for rpmlint.
sed -i 's/\r$//' MIT-LICENSE

* According to the guidelines[0] you should version ruby(release):

BuildRequires: ruby(release)
BuildRequires: ruby >= 1.9.2

* Package build fails:

From the log:

> bundle install --local
> Resolving dependencies...
> Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on
> this machine.

You need to BuildRequires: rubygem(shoulda-context)


[0] https://fedoraproject.org/wiki/Packaging:Ruby

Comment 2 Vít Ondruch 2014-07-03 07:50:29 UTC

(In reply to Josef Stribny from comment #1)
> * Change upstream URL to git repo (ideally),
> http://thoughtbot.com/community/ is just a redirect.

Good idea. Not sure why they have this silly URL in gem :/

> * This should be probably filled to upstream (and I realize now its the same
> thing for shoulda-context):
> 
> # Fix wrong-file-end-of-line-encoding for rpmlint.
> sed -i 's/\r$//' MIT-LICENSE

That is questionable. These are Mac line endings, if I was Mac developer, I'd not bother.

> * According to the guidelines[0] you should version ruby(release):
> 
> BuildRequires: ruby(release)
> BuildRequires: ruby >= 1.9.2

Fixed.

> * Package build fails:
> 
> From the log:
> 
> > bundle install --local
> > Resolving dependencies...
> > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on
> > this machine.
> 
> You need to BuildRequires: rubygem(shoulda-context)

Good catch. I missed it since I had to install it manually into my test build root.


Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-2.fc21.src.rpm

Comment 3 Josef Stribny 2014-07-03 09:24:07 UTC

Package builds, installs, runs. Spec is sane. Fixes were made. APPROVED.

Comment 4 Vít Ondruch 2014-07-03 09:43:37 UTC

Thanks for the review!

New Package SCM Request
=======================
Package Name: vondruch
Short Description: Making tests easy on the fingers and eyes
Upstream URL: https://github.com/thoughtbot/shoulda-matchers
Owners: vondruch
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2014-07-03 12:14:46 UTC

Misformatted request.  Check package name.

Comment 6 Vít Ondruch 2014-07-03 12:30:06 UTC

Ups, sorry, now it should be correct.




New Package SCM Request
=======================
Package Name: rubygem-shoulda-matchers
Short Description: Making tests easy on the fingers and eyes
Upstream URL: https://github.com/thoughtbot/shoulda-matchers
Owners: vondruch
Branches: 
InitialCC:

Comment 7 Gwyn Ciesla 2014-07-03 12:45:03 UTC

Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.