1143914 – gnuradio: build fails on s390

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1143914 - gnuradio: build fails on s390

Summary: gnuradio: build fails on s390

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	gnuradio
Sub Component:
Version:	21
Hardware:	s390
OS:	Linux
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Jaroslav Škarvada
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	ZedoraTracker
TreeView+	depends on / blocked

Reported:	2014-09-18 09:01 UTC by Jakub Čajka
Modified:	2014-11-09 15:41 UTC (History)
CC List:	4 users (show)
Fixed In Version:	gnuradio-3.7.5-3.fc21
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2014-10-14 04:31:10 UTC
Type:	Bug
Embargoed:
Dependent Products:

Attachments	(Terms of Use)
Patch (2.25 KB, patch) 2014-09-18 09:01 UTC, Jakub Čajka	no flags	Details \| Diff
Improved patch (2.37 KB, patch) 2014-09-18 09:13 UTC, Jakub Čajka	no flags	Details \| Diff
Requested patch (593 bytes, patch) 2014-09-18 09:34 UTC, Jakub Čajka	no flags	Details \| Diff
Proposed patch sent upstream (16.53 KB, patch) 2014-09-18 23:32 UTC, Jaroslav Škarvada	no flags	Details \| Diff
Show Obsolete (2) View All

Description Jakub Čajka 2014-09-18 09:01:25 UTC

Created attachment 938811 [details]
Patch

Build fails due to type incompatibilities in swig generated c++ code. Issue is cased by forcing size_t to be int on 32-bit/31-bit platforms, but on s390 size_t is long. Removing -DSIZE_T_32 swig flag fixes build on s390, but breaks build on other 32-bit platforms(similar ways as is now on s390), so patch is platform dependant. In attachment is patch with up mentioned changes.

Upstream report:
http://gnuradio.org/redmine/issues/728

Failing build:
http://s390.koji.fedoraproject.org/koji/buildinfo?buildID=235359

Successful scratch builds:
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1540031
http://koji.fedoraproject.org/koji/taskinfo?taskID=7611375

Comment 1 Jakub Čajka 2014-09-18 09:13:17 UTC

Created attachment 938813 [details]
Improved patch

Comment 2 Jaroslav Škarvada 2014-09-18 09:24:36 UTC

Thanks, but could you provide s390-build-fix.patch?

Comment 3 Jakub Čajka 2014-09-18 09:34:42 UTC

Created attachment 938818 [details]
Requested patch

Here it is.

Comment 4 Dan Horák 2014-09-18 09:44:27 UTC

Jaroslav, if possible please apply the fix to F-20 and up. Don't think anybody will use gnuradio on s390, but if possible we should get bugs fixed.

Comment 5 Jaroslav Škarvada 2014-09-18 23:30:54 UTC

(In reply to Dan Horák from comment #4)
> Jaroslav, if possible please apply the fix to F-20 and up. Don't think
> anybody will use gnuradio on s390, but if possible we should get bugs fixed.

OK, NP. BTW gnuradio can be used for various data processing not only RF and it's even used by NASA, so who knows :)

Comment 6 Jaroslav Škarvada 2014-09-18 23:32:20 UTC

Created attachment 939065 [details]
Proposed patch sent upstream

Comment 7 Jaroslav Škarvada 2014-09-19 13:35:49 UTC

Waiting for upstream.

Comment 8 Jaroslav Škarvada 2014-10-07 10:15:29 UTC

Upstream reply:

> This is more of a "wontfix for now." We might revisit this issue again in the
> future when we update our swig dependencies. The issue is correctly diagnosed,
> but the current implementation took a while to get just right that it would
> build and work on all of the known systems we support. We'd need to verify
> that the updated patch supports SWIG back to 1.3.31 (the earliest version we
> require) on a variety of the various installs we support.
> 
> For now, I would suggest you keep this patch around locally and apply it as
> needed. The code you're patching is unlikely to change. When we make a
> decision on the new minimum SWIG version in 3.8, we should revisit this issue.

So they are not against the distro fix and may later apply it upstream. Currently, I cannot see anything wrong with the fix, so let's try it and see what happen :)

Comment 9 Fedora Update System 2014-10-07 18:44:32 UTC

gnuradio-3.7.5-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/gnuradio-3.7.5-3.el7

Comment 10 Fedora Update System 2014-10-07 20:25:20 UTC

gnuradio-3.7.5-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gnuradio-3.7.5-3.fc21

Comment 11 Fedora Update System 2014-10-08 00:42:26 UTC

Package gnuradio-3.7.5-3.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing gnuradio-3.7.5-3.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-3164/gnuradio-3.7.5-3.el7
then log in and leave karma (feedback).

Comment 12 Fedora Update System 2014-10-14 04:31:10 UTC

gnuradio-3.7.5-3.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2014-10-22 21:17:19 UTC

gnuradio-3.7.5.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/gnuradio-3.7.5.1-1.el7

Comment 14 Fedora Update System 2014-11-09 15:41:07 UTC

gnuradio-3.7.5.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.