Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=82&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.8.20141028git10ca85338db00.fc21.src.rpm

* Tue Oct 28 2014 Kevin Kofler <…> - 0-0.8.20141028git10ca85338db00
- New snapshot, fixes FTBFS in Rawhide (Qt 5.4.0 beta) (calamares#125)

This one should now build in Rawhide, but there are currently broken dependencies in Rawhide (due to the LLVM upgrade) that prevent it from building right now.

I can work on reviewing this.

The Koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7964052
succeeded. (Koji has a newer Rawhide state than Copr.)

Note: The package targets only Fedora 21 and higher. Boost is too old on Fedora 20. I don't intend to target any EPEL branches, but if you are interested in those, you'll find that Boost is probably too old in all current EPEL branches, too.

Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=84&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.9.20141104gitb9af5b7d544a7.fc21.src.rpm

* Wed Nov 05 2014 Kevin Kofler <…> - 0-0.9.20141104gitb9af5b7d544a7
- New snapshot, creates sddm.conf if missing (calamares#132), adds translations
- Use and customize the new upstream .desktop file
- Point URL to the new http://calamares.github.io/ page

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/56933/

Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=87&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.10.20141106git1df44eddba572.fc21.src.rpm

* Thu Nov 06 2014 Kevin Kofler <…> - 0-0.10.20141106git1df44eddba572
- New snapshot, fixes the calamares#132 fix, calamares#124 (colors in build.log)
- Drop pkexec policy rename from desktop-file patch, fixed upstream

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/57353/

Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=88&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.11.20141107gitfd5d1935290d9.fc21.src.rpm

* Fri Nov 07 2014 Kevin Kofler <…> - 0-0.11.20141107gitfd5d1935290d9
- New snapshot, fixes the calamares#132 fix again, fixes enabling translations

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/57540/

Now the SDDM autologin setup is fixed for real. (I sent 2 pull requests fixing the remaining issues in -0.10 to upstream, they merged them.) This new snapshot also actually builds and enables the translations and fixes some other minor issues.

Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=90&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.12.20141111gitfaa77d7f5e656.fc21.src.rpm

* Tue Nov 11 2014 Kevin Kofler <…> - 0-0.12.20141111gitfaa77d7f5e656
- New snapshot, writes keyboard configuration files to the installed system
  (calamares#31), adds a language selector and dynamic retranslation support

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/59166/

OK, finally (sorry for the delay).

naming: ok

licensing: ok
$ licensecheck  -r src | cut -d: -f2 | sort | uniq
 GPL (v2 or later)
 GPL (v3 or later)
 LGPL (v2)
 *No copyright* UNKNOWN


1.  sources: NOT ok/verifiable, source URLS give 404s:
spectool -g *.spec
Getting https://github.com/calamares/calamares/archive/faa77d7f5e65620212b6abcba9bc71e55bb78f4e/calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz to ./calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found
Getting https://github.com/calamares/partitionmanager/archive/3f1ace00592088a920f731acb1e42417f71f5e62/calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz to ./calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found


2. SHOULD:   I'd also prefer if you used something closer to the SourceURL template on
https://fedoraproject.org/wiki/Packaging:SourceURL#Github
which has a shorter Release tag.


macros: ok

scriptlets: ok

%files: ok



I think the rest looks pretty good, please address item 1, and consider 2, thanks.

Looks like my 404s were a temporary github glitch

sources are verifiable now,

$ md5sum *.gz
e5c4ff39413fc2868d96402eed72dfdc  calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
853bb899693b47d43a78e6142d07e235  calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz


APPROVED.

As for the length of the release tags, https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages allows up to 13 characters for the commit ID, and I'm using exactly 13.

New Package SCM Request
=======================
Package Name: calamares
Short Description: Installer from a live CD/DVD/USB to disk
Upstream URL: http://calamares.github.io/
Owners: kkofler
Branches: f21
InitialCC:

Git done (by process-git-requests).

calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21

calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21 has been pushed to the Fedora 21 stable repository.