Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1160326 - mock new command line option --macro-file for defining rpm macros file
Summary: mock new command line option --macro-file for defining rpm macros file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-04 14:49 UTC by Mikhail Campos
Modified: 2015-01-06 02:06 UTC (History)
6 users (show)

Fixed In Version: mock-1.2.3-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-12 04:07:50 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
--macro-file option support (2.94 KB, application/mbox)
2014-11-04 14:49 UTC, Mikhail Campos 		no flags Details
correct patch for macro-file option (2.95 KB, patch)
2014-11-04 19:54 UTC, Mikhail Campos 		no flags Details | Diff
Show Obsolete (1) View All

Description Mikhail Campos 2014-11-04 14:49:45 UTC 
Created attachment 953644 [details]
--macro-file option support

Description of problem:
Right now, mock can handle rpm macros via < config_opts['macros']['xxx']= ...> or via < --define > command line option. However, is not very usable, when we need to define a lot of rpm macros or need to migrate from other build rpm solutions. The suggestion consist of using new --macro-file option which points to file with rpm macros definitions. 

Also, note, that using this option is lower priority relative to config_opts['macro'] and --define, that adds additional flexibility in setup build environment.

Version-Release number of selected component (if applicable):
1.2.0.-1

Proposed patch:
Patch attached.
Comment 1 Mikhail Campos 2014-11-04 19:54:12 UTC 
Created attachment 953796 [details]
correct patch for macro-file option

Sorry, correct patch is macrofile-option.patch
Comment 2 Miroslav Suchý 2014-11-05 08:02:51 UTC 
Thanks for contribution.
I fixed some code styles and trailing whitespace and committed as ccd84ca.
And I edited man page to document this new option (commit bcf240c)
Comment 3 Fedora Update System 2014-11-16 17:37:17 UTC 
mock-1.2.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mock-1.2.1-1.fc21
Comment 4 Fedora Update System 2014-11-16 17:38:41 UTC 
mock-1.2.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mock-1.2.1-1.fc20
Comment 5 Fedora Update System 2014-11-16 17:39:33 UTC 
mock-1.2.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.1-1.el7
Comment 6 Fedora Update System 2014-11-16 17:40:31 UTC 
mock-1.2.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.2.1-1.el6
Comment 7 Fedora Update System 2014-11-17 06:29:37 UTC 
Package mock-1.2.1-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mock-1.2.1-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15217/mock-1.2.1-1.fc20
then log in and leave karma (feedback).
Comment 8 Fedora Update System 2014-12-04 12:06:55 UTC 
mock-1.2.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mock-1.2.3-1.fc21
Comment 9 Fedora Update System 2014-12-04 12:10:25 UTC 
mock-1.2.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mock-1.2.3-1.fc20
Comment 10 Fedora Update System 2014-12-04 12:11:22 UTC 
mock-1.2.3-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.3-1.el7
Comment 11 Fedora Update System 2014-12-12 04:07:50 UTC 
mock-1.2.3-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2014-12-17 04:42:54 UTC 
mock-1.2.3-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2015-01-06 02:06:39 UTC 
mock-1.2.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.