Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1162303 (kde-plasma-redshift) - Review Request: kde-plasma-redshift - Plasmoid for redshift
Summary: Review Request: kde-plasma-redshift - Plasmoid for redshift
Keywords:
Status: CLOSED ERRATA
Alias: kde-plasma-redshift
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2014-11-10 19:32 UTC by Christian Dersch
Modified: 2015-02-09 13:32 UTC (History)
4 users (show)

Fixed In Version: kde-plasma-redshift-1.0-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-01 08:54:38 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Christian Dersch 2014-11-10 19:32:21 UTC 
Spec URL: https://lupinix.fedorapeople.org/kde-plasma-redshift.spec
SRPM URL: https://lupinix.fedorapeople.org/kde-plasma-redshift-1.0-1.fc20.src.rpm

Description: Redshift plasmoid provides a configuration interface and allows to start/stop redshift daemon either manually or automatically based on the current activity.

Fedora Account System Username: lupinix

Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091863
Koji build f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091883
Koji build f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091889
Koji build f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091893

Thank you for review in advance!
Comment 1 Rex Dieter 2014-11-10 20:36:28 UTC 
Some initial comments,

1. SHOULD use
BuildRequires: kdelibs4-devel
(instead of kdelibs-devel, in case kdelibs-devel ever moves to v5)

2. in %files SHOULD use
%{_kde4_iconsdir}/hicolor/*/*/*
instead
and relatedly...

3. MUST include icon cache scriplets per
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Comment 2 Christian Dersch 2014-11-10 20:41:57 UTC 
Thanks for your useful comments :) I will include this soon.
Comment 3 Christian Dersch 2014-11-10 23:03:41 UTC 
Spec URL: https://lupinix.fedorapeople.org/kde-plasma-redshift.spec
SRPM URL: https://lupinix.fedorapeople.org/kde-plasma-redshift-1.0-2.fc20.src.rpm

Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8092782

Fixed the issues :)
Comment 4 Rex Dieter 2014-12-22 17:02:46 UTC 
I can review this today.
Comment 5 Rex Dieter 2014-12-22 17:09:33 UTC 
naming: ok

sources: ok
32b142c966d496e50bebb599e374b1c0  v1.0.tar.gz

license: ok

scriptlets: ok

macros: ok


You may want to consider updating project URL, sources to point to
http://simgunz.org/projects/redshift-plasmoid


Otherwise, simple and clean, APPROVED.
Comment 6 Christian Dersch 2014-12-22 18:22:37 UTC 
Thank you for reviewing the package :) Will update the URL.
Comment 7 Christian Dersch 2014-12-22 18:25:13 UTC 
New Package SCM Request
=======================
Package Name: kde-plasma-redshift
Short Description: Plasmoid for redshift
Upstream URL: http://simgunz.org/projects/redshift-plasmoid
Owners: lupinix
Branches: f20 f21
InitialCC:
Comment 8 Gwyn Ciesla 2014-12-22 19:36:41 UTC 
Git done (by process-git-requests).
Comment 9 Fedora Update System 2014-12-22 22:23:03 UTC 
kde-plasma-redshift-1.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/kde-plasma-redshift-1.0-2.fc21
Comment 10 Fedora Update System 2014-12-22 22:24:01 UTC 
kde-plasma-redshift-1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kde-plasma-redshift-1.0-2.fc20
Comment 11 Fedora Update System 2014-12-23 18:26:20 UTC 
kde-plasma-redshift-1.0-2.fc20 has been pushed to the Fedora 20 testing repository.
Comment 12 Fedora Update System 2015-01-01 08:54:38 UTC 
kde-plasma-redshift-1.0-2.fc21 has been pushed to the Fedora 21 stable repository.
Comment 13 Fedora Update System 2015-01-01 08:57:50 UTC 
kde-plasma-redshift-1.0-2.fc20 has been pushed to the Fedora 20 stable repository.
Note You need to log in before you can comment on or make changes to this bug.