Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1164454 - hg pull takes a log time to complete
Summary: hg pull takes a log time to complete
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: mercurial
Version: 21
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Neal Becker
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-15 15:08 UTC by Bill Gianopoulos
Modified: 2015-01-11 15:50 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-13 13:39:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Testcase (374 bytes, text/plain)
2014-11-15 20:14 UTC, Bill Gianopoulos
no flags Details

Description Bill Gianopoulos 2014-11-15 15:08:29 UTC
Description of problem: an hg pull operation never completes.

THis works fine using the fedora 20 latest version of mercurial.


Version-Release number of selected component (if applicable): 3.0


How reproducible: just do an hg pull on a mercurial repository.  it outputs the added xxx changesets with xxx changes to xxx files messages and then just never seems to finish.

Comment 1 Bill Gianopoulos 2014-11-15 20:13:05 UTC
The original comment was not really correct.  This does complete after about 30 minutes, however it takes under 30 seconds with fedora 20, so there is still something amiss here.

Comment 2 Bill Gianopoulos 2014-11-15 20:14:47 UTC
Created attachment 957866 [details]
Testcase

This is a simplified snippet from my Firefox build procedure which exhibits the issue.

Comment 3 Bill Gianopoulos 2014-12-12 12:27:16 UTC
Here is the output from "time hg pull" using the mercurial-3.0-2.fc21.x86_64 package that is the current fedora 21 version:

pulling from http://hg.mozilla.org/mozilla-central/
searching for changes
adding changesets
adding manifests
adding file changes
added 742 changesets with 4957 changes to 2526 files
(run 'hg update' to get a working copy)

real    25m31.661s
user    25m26.505s
sys     0m1.244s

After downgrading to the mercurial-2.8-1.fc20.x86_64 package, as you can see it goes from over 25 minutes to under 9 seconds:

pulling from http://hg.mozilla.org/mozilla-central/
searching for changes
adding changesets
adding manifests
adding file changes
added 742 changesets with 4957 changes to 2526 files
(run 'hg update' to get a working copy)

real    0m8.746s
user    0m6.540s
sys     0m0.702s

All of the extra time taken occurs between the time it outputs the line "added 742 changesets with 4957 changes to 2526 files" and the line "(run 'hg update' to get a working copy)".

Comment 4 Neal Becker 2014-12-12 12:43:36 UTC
I've reported this upstream, see what they have to say...

Comment 5 Neal Becker 2014-12-12 16:13:43 UTC
Can you try the 3.2 build in:

http://copr-be.cloud.fedoraproject.org/results/nbecker/mercurial-3/

Comment 6 Bill Gianopoulos 2014-12-12 19:45:21 UTC
(In reply to Neal Becker from comment #5)
> Can you try the 3.2 build in:
> 
> http://copr-be.cloud.fedoraproject.org/results/nbecker/mercurial-3/

I can try that but further testing seems to make it seem that the real issue here is that there is some kind of first time version 2 to version 3 conversion that is not happening if you take a version 2 bundle and do and hg init hg unbundle 
and it gets done at the next pull

I tried going back a few revs and doing an hg clone of this repository and it is doing the same long seeming to not be doing anything at the same point.  I bet the pull will go lickety split.  after that I will try this 3.2 version.  if the issue had originally occurred at the unblundle step I would have recognized it as a version difference thing.  but the unbundle and pull are happening with the same version so you would not expect that to b
e where any such conversion occurs.

Comment 7 Neal Becker 2014-12-12 19:58:55 UTC
Please see:

http://comments.gmane.org/gmane.comp.version-control.mercurial.devel/74545

It is claimed that this bug is almost certainly fixed in 3.1+.

I'm just the messenger here, I'm not an expert on hg.

Comment 8 Bill Gianopoulos 2014-12-12 20:01:30 UTC
(In reply to Neal Becker from comment #7)
> Please see:
> 
> http://comments.gmane.org/gmane.comp.version-control.mercurial.devel/74545
> 
> It is claimed that this bug is almost certainly fixed in 3.1+.
> 
> I'm just the messenger here, I'm not an expert on hg.

Yes thsi seems to fix it.  Thank you so much!

Comment 9 Neal Becker 2014-12-13 13:39:26 UTC
Good.  I'll try to see what I can do to update (it has to be coordinated with tortoisehg)

Comment 10 Fedora Update System 2014-12-16 01:15:26 UTC
tortoisehg-3.2.1-1.fc21,mercurial-3.2.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/tortoisehg-3.2.1-1.fc21,mercurial-3.2.2-1.fc21

Comment 11 Bill Gianopoulos 2015-01-11 15:50:48 UTC
Hmm this is closed, however, the update (which should probably really be to 3.2.3) is still not available via fedora updates.


Note You need to log in before you can comment on or make changes to this bug.