Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1169118 - Review Request: nodejs-domelementtype - All the types of nodes in htmlparser2's dom
Summary: Review Request: nodejs-domelementtype - All the types of nodes in htmlparser2...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1169121 1169124
TreeView+ depends on / blocked
 
Reported: 2014-11-30 13:21 UTC by Piotr Popieluch
Modified: 2014-12-26 19:48 UTC (History)
2 users (show)

Fixed In Version: nodejs-domelementtype-1.1.3-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-14 12:41:04 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Piotr Popieluch 2014-11-30 13:21:42 UTC 
Spec URL: https://piotrp.fedorapeople.org/nodejs-domelementtype.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-domelementtype-1.1.3-1.fc21.src.rpm
Description: All the types of nodes in htmlparser2's dom
Fedora Account System Username: piotrp
Comment 1 Parag AN(पराग) 2014-12-06 12:19:37 UTC 
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-domelementtype.noarch: W: spelling-error Summary(en_US) dom -> mod, dim, don
nodejs-domelementtype.noarch: W: spelling-error %description -l en_US dom -> mod, dim, don
nodejs-domelementtype.noarch: W: only-non-binary-in-usr-lib
nodejs-domelementtype.src: W: spelling-error Summary(en_US) dom -> mod, dim, don
nodejs-domelementtype.src: W: spelling-error %description -l en_US dom -> mod, dim, don
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3
upstream tarball:  40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3

- License is "BSD" but in spec its written "MIT"

+ License test is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional and can be removed.

2) Fix license tag.
Comment 2 Piotr Popieluch 2014-12-06 13:53:02 UTC 
Thank you for review, Fixed suggestions:

Spec URL: https://piotrp.fedorapeople.org/nodejs-domelementtype.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-domelementtype-1.1.3-2.fc21.src.rpm
Comment 3 Parag AN(पराग) 2014-12-06 13:58:23 UTC 
Looks good.

APPROVED.
Comment 4 Gwyn Ciesla 2014-12-08 20:26:00 UTC 
No SCM request.
Comment 5 Piotr Popieluch 2014-12-09 09:57:54 UTC 
New Package SCM Request
=======================
Package Name: nodejs-domelementtype
Short Description: All the types of nodes in htmlparser2's dom
Upstream URL: https://github.com/FB55/domelementtype
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
Comment 6 Gwyn Ciesla 2014-12-10 15:08:41 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2014-12-10 19:22:08 UTC 
nodejs-domelementtype-1.1.3-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc21
Comment 8 Fedora Update System 2014-12-10 19:22:51 UTC 
nodejs-domelementtype-1.1.3-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc20
Comment 9 Fedora Update System 2014-12-10 19:23:29 UTC 
nodejs-domelementtype-1.1.3-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc19
Comment 10 Fedora Update System 2014-12-10 19:24:02 UTC 
nodejs-domelementtype-1.1.3-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.el7
Comment 11 Fedora Update System 2014-12-11 06:33:09 UTC 
nodejs-domelementtype-1.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
Comment 12 Piotr Popieluch 2014-12-14 12:41:04 UTC 
Package built and in testing, closing bug.
Comment 13 Fedora Update System 2014-12-20 08:36:58 UTC 
nodejs-domelementtype-1.1.3-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 14 Fedora Update System 2014-12-20 08:39:47 UTC 
nodejs-domelementtype-1.1.3-2.fc20 has been pushed to the Fedora 20 stable repository.
Comment 15 Fedora Update System 2014-12-20 08:41:20 UTC 
nodejs-domelementtype-1.1.3-2.fc21 has been pushed to the Fedora 21 stable repository.
Comment 16 Fedora Update System 2014-12-26 19:48:26 UTC 
nodejs-domelementtype-1.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
Note You need to log in before you can comment on or make changes to this bug.