Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1169137 - Review Request: nodejs-htmlparser2 - Fast & forgiving HTML/XML/RSS parser
Summary: Review Request: nodejs-htmlparser2 - Fast & forgiving HTML/XML/RSS parser
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1169121 1169123 1169124
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-30 16:54 UTC by Piotr Popieluch
Modified: 2014-12-29 19:04 UTC (History)
2 users (show)

Fixed In Version: nodejs-htmlparser2-3.8.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-19 20:07:40 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Piotr Popieluch 2014-11-30 16:54:35 UTC 
Spec URL: https://piotrp.fedorapeople.org/nodejs-htmlparser2.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-htmlparser2-3.8.2-1.fc21.src.rpm
Description: Fast & forgiving HTML/XML/RSS parser
Fedora Account System Username: piotrp
Comment 1 Parag AN(पराग) 2014-12-11 05:55:09 UTC 
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-htmlparser2.noarch: W: only-non-binary-in-usr-lib
nodejs-htmlparser2.noarch: W: dangling-symlink /usr/lib/node_modules/htmlparser2/node_modules/entities /usr/lib/node_modules/entities
nodejs-htmlparser2.noarch: W: dangling-symlink /usr/lib/node_modules/htmlparser2/node_modules/domutils /usr/lib/node_modules/domutils
nodejs-htmlparser2.noarch: W: dangling-symlink /usr/lib/node_modules/htmlparser2/node_modules/domelementtype /usr/lib/node_modules/domelementtype
nodejs-htmlparser2.noarch: W: dangling-symlink /usr/lib/node_modules/htmlparser2/node_modules/readable-stream /usr/lib/node_modules/readable-stream
nodejs-htmlparser2.noarch: W: dangling-symlink /usr/lib/node_modules/htmlparser2/node_modules/domhandler /usr/lib/node_modules/domhandler
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: a590cb45b58657bb4f921318d3658aed8a5d2fdaf795e24d5219ff7833d59c83
upstream tarball:  a590cb45b58657bb4f921318d3658aed8a5d2fdaf795e24d5219ff7833d59c83

+ License is "MIT" and included in its own LICENCE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed

2) rm -rf node_modules in %prep needed

APPROVED.
Comment 2 Piotr Popieluch 2014-12-11 06:51:17 UTC 
New Package SCM Request
=======================
Package Name: nodejs-htmlparser2
Short Description: Fast & forgiving HTML/XML/RSS parser
Upstream URL: https://github.com/fb55/htmlparser2
Owners: piotrp
Branches: f20 f21 el6 epel7
Comment 3 Gwyn Ciesla 2014-12-12 14:06:40 UTC 
Git done (by process-git-requests).
Comment 4 Fedora Update System 2014-12-14 13:23:48 UTC 
nodejs-htmlparser2-3.8.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-htmlparser2-3.8.2-1.fc21
Comment 5 Fedora Update System 2014-12-14 13:24:14 UTC 
nodejs-htmlparser2-3.8.2-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-htmlparser2-3.8.2-1.el7
Comment 6 Fedora Update System 2014-12-14 22:08:14 UTC 
nodejs-htmlparser2-3.8.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
Comment 7 Fedora Update System 2014-12-23 18:25:32 UTC 
nodejs-htmlparser2-3.8.2-1.fc21 has been pushed to the Fedora 21 stable repository.
Comment 8 Fedora Update System 2014-12-29 19:04:31 UTC 
nodejs-htmlparser2-3.8.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
Note You need to log in before you can comment on or make changes to this bug.