Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1171226 - Review Request: nodejs-unicode-7.0.0 - JavaScript-compatible Unicode 7.0.0 data
Summary: Review Request: nodejs-unicode-7.0.0 - JavaScript-compatible Unicode 7.0.0 data
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Piotr Popieluch
QA Contact: Fedora Extras Quality Assurance
Piotr Popieluch
Depends On:
Blocks: nodejs-reviews 1171227
TreeView+ depends on / blocked
Reported: 2014-12-05 17:10 UTC by Parag Nemade
Modified: 2014-12-26 19:51 UTC (History)
2 users (show)

Fixed In Version: nodejs-unicode-7.0.0-0.1.5-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-12-10 09:05:07 UTC
Type: ---
piotr1212: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Parag Nemade 2014-12-05 17:10:35 UTC
Spec URL:
JavaScript-compatible Unicode data. Arrays of code points, arrays of symbols,
and regular expressions for Unicode v7.0.0’s categories, scripts, blocks,
bidi, and other properties.

Fedora Account System Username: pnemade

Comment 1 Piotr Popieluch 2014-12-07 13:12:59 UTC
Summary is incorrect.

Rest is all correct, please fix the summary and I will approve.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1495 files have unknown license. Detailed output
     of licensecheck in /home/piotr/rpmbuild/nodejs-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: nodejs-unicode-7.0.0-0.1.5-1.fc21.noarch.rpm
nodejs-unicode-7.0.0.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-unicode-7.0.0.noarch: W: only-non-binary-in-usr-lib
nodejs-unicode-7.0.0.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-unicode-7.0.0.src: W: spelling-error %description -l en_US bidi -> ibid, bid, bide
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages)
# rpmlint nodejs-unicode-7.0.0
nodejs-unicode-7.0.0.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-unicode-7.0.0.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

nodejs-unicode-7.0.0 (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 8d99cf73b6840ec51f825c330150e9c33ea27967bda1d673358a4c6b19eb41e1
  CHECKSUM(SHA256) upstream package : 8d99cf73b6840ec51f825c330150e9c33ea27967bda1d673358a4c6b19eb41e1 :
  CHECKSUM(SHA256) this package     : 483acb265f182907d1caf6cff9c16c96f31325ed23792832cc5d8b12d5f88c8a
  CHECKSUM(SHA256) upstream package : 483acb265f182907d1caf6cff9c16c96f31325ed23792832cc5d8b12d5f88c8a

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --rpm-spec -n SRPMS/nodejs-unicode-7.0.0-0.1.5-1.fc21.src.rpm
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 3 Piotr Popieluch 2014-12-07 13:23:15 UTC
Looks good now, approved

Comment 4 Parag Nemade 2014-12-07 14:51:54 UTC
Thank you for this review.

New Package SCM Request
Package Name: nodejs-unicode-7.0.0
Short Description: JavaScript-compatible Unicode 7.0.0 data
Upstream URL:
Owners: pnemade
Branches: f19 f20 f21 el6 epel7

Comment 5 Gwyn Ciesla 2014-12-08 14:18:29 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-12-08 16:48:27 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc21 has been submitted as an update for Fedora 21.

Comment 7 Fedora Update System 2014-12-08 16:59:44 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc20 has been submitted as an update for Fedora 20.

Comment 8 Fedora Update System 2014-12-08 17:07:33 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc19 has been submitted as an update for Fedora 19.

Comment 9 Fedora Update System 2014-12-08 17:31:22 UTC
nodejs-unicode-7.0.0-0.1.5-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 10 Fedora Update System 2014-12-08 17:56:03 UTC
nodejs-unicode-7.0.0-0.1.5-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 11 Parag Nemade 2014-12-10 09:05:07 UTC
Closing this review as package is built now,

Comment 12 Fedora Update System 2014-12-20 08:43:45 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2014-12-20 08:45:50 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2014-12-20 08:48:38 UTC
nodejs-unicode-7.0.0-0.1.5-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2014-12-26 19:47:16 UTC
nodejs-unicode-7.0.0-0.1.5-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 16 Fedora Update System 2014-12-26 19:51:49 UTC
nodejs-unicode-7.0.0-0.1.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.