Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1171233 - Review Request: nodejs-timed-out - Timeout HTTP/HTTPS requests
Summary: Review Request: nodejs-timed-out - Timeout HTTP/HTTPS requests
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Piotr Popieluch
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews 1171236
TreeView+ depends on / blocked
Reported: 2014-12-05 17:11 UTC by Parag Nemade
Modified: 2014-12-26 19:48 UTC (History)
2 users (show)

Fixed In Version: nodejs-timed-out-2.0.0-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-12-10 09:05:09 UTC
Type: ---
piotr1212: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Parag Nemade 2014-12-05 17:11:00 UTC
Spec URL:
Timeout HTTP/HTTPS requests. Emit Error object with code property
equal ETIMEDOUT or ESOCKETTIMEDOUT when ClientRequest is hanged.

Fedora Account System Username: pnemade

Comment 2 Piotr Popieluch 2014-12-07 16:54:48 UTC
Source2 url incorrect, 404 not found, please correct or remove as it is not used.

Package looks good for the rest.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/piotr/rpmbuild/nodejs-

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 2 files have unknown license. Detailed output of
     licensecheck in /home/piotr/rpmbuild/nodejs-timed-out/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source2:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: nodejs-timed-out-2.0.0-2.fc21.noarch.rpm
nodejs-timed-out.noarch: W: only-non-binary-in-usr-lib
nodejs-timed-out.src: W: invalid-url Source2: HTTP Error 404: Not Found
nodejs-timed-out.src: W: file-size-mismatch license = 1119, = 1105
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (installed packages)
# rpmlint nodejs-timed-out
nodejs-timed-out.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'

nodejs-timed-out (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 7b10bb2eaf93f11f9c7740257b772b6c7d2460db85a83be3b45f13da92c3cdcf
  CHECKSUM(SHA256) upstream package : 7b10bb2eaf93f11f9c7740257b772b6c7d2460db85a83be3b45f13da92c3cdcf :
  CHECKSUM(SHA256) this package     : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c
  CHECKSUM(SHA256) upstream package : e19885e03f3554a6725a89ba1ff33015589c6e2edb2f939e04d10a26db33d6ef
diff -r also reports differences

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --rpm-spec -n /home/piotr/rpmbuild/SRPMS/nodejs-timed-out-2.0.0-2.fc21.src.rpm
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 3 Parag Nemade 2014-12-07 17:00:48 UTC
These upstream problems are creating more packaging for us. The source2 issue is fixed now

Spec URL:

Note I have not bumped the release.

Comment 4 Piotr Popieluch 2014-12-07 17:19:25 UTC
Not really sure if I'm mixing up but it seems that the License in SRPM differs from the upstream license..?? Could you check before importing in SCM?

package APPROVED

- Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/piotr/rpmbuild/nodejs-

➜  rpmbuild  cat /home/piotr/rpmbuild/nodejs-timed-out/diff.txt 
diff -U2 -r /home/piotr/rpmbuild/nodejs-timed-out/upstream-unpacked/Source1/license /home/piotr/rpmbuild/nodejs-timed-out/srpm-unpacked/license-extract/license
--- /home/piotr/rpmbuild/nodejs-timed-out/upstream-unpacked/Source1/license	2014-12-07 18:10:27.022911945 +0100
+++ /home/piotr/rpmbuild/nodejs-timed-out/srpm-unpacked/license-extract/license	2014-12-07 18:10:27.041912175 +0100
@@ -1,5 +1,5 @@
 The MIT License (MIT)
-Copyright (c) Vsevolod Strukchinsky <floatdrop>
+Copyright (c) Sindre Sorhus <sindresorhus> (
 Permission is hereby granted, free of charge, to any person obtaining a copy

Comment 5 Parag Nemade 2014-12-07 17:47:51 UTC
Ah I got it. I mixed source with other packages. Thank you for approving. I have fixed this issue below.

Spec URL:

Comment 6 Parag Nemade 2014-12-07 17:59:10 UTC
New Package SCM Request
Package Name: nodejs-timed-out
Short Description: Timeout HTTP/HTTPS requests
Upstream URL:
Owners: pnemade
Branches: f19 f20 f21 el6 epel7

Comment 7 Gwyn Ciesla 2014-12-08 14:24:13 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-12-08 16:59:05 UTC
nodejs-timed-out-2.0.0-2.fc21 has been submitted as an update for Fedora 21.

Comment 9 Fedora Update System 2014-12-08 17:09:53 UTC
nodejs-timed-out-2.0.0-2.fc20 has been submitted as an update for Fedora 20.

Comment 10 Fedora Update System 2014-12-08 17:33:09 UTC
nodejs-timed-out-2.0.0-2.fc19 has been submitted as an update for Fedora 19.

Comment 11 Fedora Update System 2014-12-08 17:40:10 UTC
nodejs-timed-out-2.0.0-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 12 Fedora Update System 2014-12-09 00:58:27 UTC
nodejs-timed-out-2.0.0-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 13 Parag Nemade 2014-12-10 09:05:09 UTC
Closing this review as package is built now,

Comment 14 Fedora Update System 2014-12-20 08:35:52 UTC
nodejs-timed-out-2.0.0-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 15 Fedora Update System 2014-12-20 08:42:37 UTC
nodejs-timed-out-2.0.0-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 16 Fedora Update System 2014-12-20 08:48:47 UTC
nodejs-timed-out-2.0.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 17 Fedora Update System 2014-12-26 19:47:31 UTC
nodejs-timed-out-2.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 18 Fedora Update System 2014-12-26 19:48:45 UTC
nodejs-timed-out-2.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.