Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1172976 - Review Request: nodejs-follow - Extremely robust, fault-tolerant CouchDB changes follower
Summary: Review Request: nodejs-follow - Extremely robust, fault-tolerant CouchDB cha...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Piotr Popieluch
QA Contact: Piotr Popieluch
URL:
Whiteboard:
Depends On: 1173387
Blocks: nodejs-reviews 1172977
TreeView+ depends on / blocked
 
Reported: 2014-12-11 08:46 UTC by Parag Nemade
Modified: 2015-01-17 19:16 UTC (History)
2 users (show)

Fixed In Version: nodejs-follow-0.11.4-2.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-31 04:53:35 UTC
Type: ---
Embargoed:
piotr1212: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Parag Nemade 2014-12-11 08:46:15 UTC
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-follow.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-follow-0.11.4-1.fc21.src.rpm
Description: 
Follow (upper-case F) comes from an internal Iris Couch project used in
production for over a year. It works in the browser (beta) and is
available as an NPM module.
Fedora Account System Username: pnemade

Comment 1 Piotr Popieluch 2014-12-27 17:40:17 UTC
- spec file in srpm differs

- incorrect symlink for binary:
  please change:
  ln -s %{nodejs_sitelib}/%{module_name}/bin/cli.js %{buildroot}%{_bindir}/follow
  into:
  ln -s %{nodejs_sitelib}/%{module_name}/cli.js %{buildroot}%{_bindir}/follow

- rpmlint error
  nodejs-follow.noarch: E: non-executable-script /usr/lib/node_modules/follow/browser/export.js 0644L /usr/bin/env




     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: nodejs-follow-0.11.4-1.fc22.noarch.rpm
          nodejs-follow-0.11.4-1.fc22.src.rpm
nodejs-follow.noarch: W: only-non-binary-in-usr-lib
nodejs-follow.noarch: W: dangling-symlink /usr/bin/follow /usr/lib/node_modules/follow/bin/cli.js
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/browser-request /usr/lib/node_modules/browser-request
n


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 14 files have unknown license.
     Detailed output of licensecheck in /home/piotr/rpmbuild/1172976-nodejs-
     follow/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: nodejs-follow-0.11.4-1.fc22.noarch.rpm
          nodejs-follow-0.11.4-1.fc22.src.rpm
nodejs-follow.noarch: W: only-non-binary-in-usr-lib
nodejs-follow.noarch: W: dangling-symlink /usr/bin/follow /usr/lib/node_modules/follow/bin/cli.js
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/browser-request /usr/lib/node_modules/browser-request
nodejs-follow.noarch: E: non-executable-script /usr/lib/node_modules/follow/browser/export.js 0644L /usr/bin/env
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/request /usr/lib/node_modules/request
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/debug /usr/lib/node_modules/debug
nodejs-follow.noarch: W: no-manual-page-for-binary follow
2 packages and 0 specfiles checked; 1 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@pontifex /]# rpmlint nodejs-follow
nodejs-follow.noarch: W: invalid-url URL: http://github.com/dscape/nano <urlopen error [Errno -3] Temporary failure in name resolution>
nodejs-follow.noarch: W: only-non-binary-in-usr-lib
nodejs-follow.noarch: W: dangling-symlink /usr/bin/follow /usr/lib/node_modules/follow/bin/cli.js
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/browser-request /usr/lib/node_modules/browser-request
nodejs-follow.noarch: E: non-executable-script /usr/lib/node_modules/follow/browser/export.js 0644L /usr/bin/env
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/request /usr/lib/node_modules/request
nodejs-follow.noarch: W: dangling-symlink /usr/lib/node_modules/follow/node_modules/debug /usr/lib/node_modules/debug
nodejs-follow.noarch: W: no-manual-page-for-binary follow
1 packages and 0 specfiles checked; 1 errors, 7 warnings.
]0;<mock-chroot><mock-chroot>[root@pontifex /]# echo 'rpmlint-done:'



Diff spec file in url and in SRPM
---------------------------------
--- /home/piotr/rpmbuild/1172976-nodejs-follow/srpm/nodejs-follow.spec	2014-12-27 18:19:32.018729148 +0100
+++ /home/piotr/rpmbuild/1172976-nodejs-follow/srpm-unpacked/nodejs-follow.spec	2014-12-09 09:58:09.000000000 +0100
@@ -1,3 +1,3 @@
-%global enable_tests 1
+%global enable_tests 0
 %global module_name follow
 


Requires
--------
nodejs-follow (rpmlib, GLIBC filtered):
    /usr/bin/env
    nodejs(engine)
    npm(browser-request)
    npm(debug)
    npm(request)



Provides
--------
nodejs-follow:
    nodejs-follow
    npm(follow)



Source checksums
----------------
http://registry.npmjs.org/follow/-/follow-0.11.4.tgz :
  CHECKSUM(SHA256) this package     : edc9c4c850394332cf16e35a62474f72022f4815d8ea2a2e48495d041723a903
  CHECKSUM(SHA256) upstream package : edc9c4c850394332cf16e35a62474f72022f4815d8ea2a2e48495d041723a903


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1172976
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 2 Parag Nemade 2014-12-28 03:01:56 UTC
Tests are disabled. Will work with upstream to fix errors.

Updated package as
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-follow.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-follow-0.11.4-2.fc21.src.rpm

Comment 3 Parag Nemade 2014-12-28 11:28:21 UTC
Found that tests need couchdb running. I think I better keep them disabled.

Comment 4 Piotr Popieluch 2014-12-28 11:34:41 UTC
new version solves all issues. 

APPROVED

Comment 5 Parag Nemade 2014-12-28 12:26:19 UTC
Thank you for this review.

New Package SCM Request
=======================
Package Name: nodejs-follow
Short Description: Extremely robust, fault-tolerant CouchDB changes follower
Upstream URL: https://github.com/iriscouch/follow
Owners: pnemade
Branches: f20 f21 el6 epel7
InitialCC:

Comment 6 Kevin Fenzi 2014-12-29 16:55:31 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-12-30 08:32:50 UTC
nodejs-follow-0.11.4-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-follow-0.11.4-2.el7

Comment 8 Fedora Update System 2014-12-30 08:32:55 UTC
nodejs-follow-0.11.4-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-follow-0.11.4-2.fc21

Comment 9 Fedora Update System 2014-12-30 08:33:09 UTC
nodejs-follow-0.11.4-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/nodejs-follow-0.11.4-2.el6

Comment 10 Fedora Update System 2014-12-30 08:37:02 UTC
nodejs-follow-0.11.4-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-follow-0.11.4-2.fc20

Comment 11 Parag Nemade 2014-12-31 04:53:35 UTC
Built in rawhide.

Comment 12 Fedora Update System 2015-01-07 23:52:42 UTC
nodejs-follow-0.11.4-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2015-01-08 23:32:57 UTC
nodejs-follow-0.11.4-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2015-01-15 17:42:56 UTC
nodejs-follow-0.11.4-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 15 Fedora Update System 2015-01-17 19:16:33 UTC
nodejs-follow-0.11.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.