Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1176993 - gawk spec file %check rule is incorrect
Summary: gawk spec file %check rule is incorrect
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gawk
Version: 21
Hardware: All
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-23 17:02 UTC by Andrew J. Schorr
Modified: 2015-01-17 05:49 UTC (History)
2 users (show)

Fixed In Version: gawk-4.1.0-4.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-13 00:03:09 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Andrew J. Schorr 2014-12-23 17:02:23 UTC 
Description of problem: In gawk.spec, it says:

%check
make check diffout

That is invalid, since "make check diffout" will exit with successful zero status even if errors are detected.  It should say instead "make check".
Note that Fedora 20 gawk was somehow built with byacc instead of bison, so the binary actually fails "make check" on 2 tests.

A separate mystery is how you guys managed to build gawk with byacc instead of bison.  The tarball contains the awkgram.c file, so there should be no need to run YACC again.  What's going on in your build environment that caused byacc to be used to regenerate awkgram.c?



Version-Release number of selected component (if applicable):
gawk-4.1.1-5.fc21.src.rpm

How reproducible:
Look at the spec file.  The %check rule is wrong.

Steps to Reproduce:
1. Examine gawk.spec %check rule.
2.
3.

Actual results:
make check diffout

Expected results:
make check

Additional info:
Comment 1 Jan Chaloupka 2015-01-02 14:08:39 UTC 
Hi Andrew,

during building awkgram.c is not regenerated. Thus building is succesfull. With the original awkgram.c make check passes. There is no need for bison/byacc build dependency. Updating the spec file.
Comment 2 Andrew J. Schorr 2015-01-02 14:26:44 UTC 
Hi Jan,

In cases where the Fedora rpm includes patches that touch awkgram.y and/or command.y, "make" may try to run YACC on the parser.  For example, gawk-4.1.0-3.fc20.src.rpm contains a patch that touches awkgram.y and awkgram.c.  If awkgram.y is touched after awkgram.c, then "make" tries to rebuild awkgram.c.  So I request that you replace "BuildRequires: byacc" with "BuildRequires: bison".  This will be MUCH safer going forward and ensure that gawk is built properly on Fedora under all circumstances.  Testing with the Fedora 20 binary seems to indicate that gawk was built using byacc, and that is not what we want out in the field.  That somehow seems also to be true of the Fedora 21 binary, although I don't know why, since that source rpm does not contain any patches to awkgram.y.

Thanks,
Andy
Comment 3 Andrew J. Schorr 2015-01-02 14:30:36 UTC 
Hi,

Actually, the Fedora 21 binary looks like it may be OK.  But Fedora 20 x86_64 is definitely not parsing properly.

Regards,
Andy
Comment 4 Fedora Update System 2015-01-02 15:46:46 UTC 
gawk-4.1.0-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gawk-4.1.0-4.fc20
Comment 5 Fedora Update System 2015-01-02 15:47:06 UTC 
gawk-4.1.1-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gawk-4.1.1-6.fc21
Comment 6 Fedora Update System 2015-01-03 19:04:16 UTC 
Package gawk-4.1.0-4.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gawk-4.1.0-4.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-0069/gawk-4.1.0-4.fc20
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2015-01-13 00:03:09 UTC 
gawk-4.1.1-6.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2015-01-17 05:49:19 UTC 
gawk-4.1.0-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.