Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1182005 - socat 1.7.2.4 build failure missing linux/errqueue.h
Summary: socat 1.7.2.4 build failure missing linux/errqueue.h
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: socat
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paul Wouters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-14 09:42 UTC by Michel Normand
Modified: 2015-12-02 17:04 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-02 07:24:53 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
socat_1.7.2.4_fix_linux_errqueue_h_not_found.patch (2.45 KB, patch)
2015-01-14 09:45 UTC, Michel Normand 		no flags Details | Diff
errqueue.patch (2.63 KB, patch)
2015-01-22 12:45 UTC, Michel Normand 		no flags Details | Diff
Show Obsolete (1) View All

Description Michel Normand 2015-01-14 09:42:10 UTC 
Description of problem: socat do not build for ppc64 architecture
because missing linux/errqueue.h

Version-Release number of selected component (if applicable):
socat 1.7.2.4


Steps to Reproduce:
1. fedpkg clone -a socat
2. fedpkg srpm socat 
3. fedpkg build socat

Actual results:
===                                                                             gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -D_GNU_SOURCE -Wall -Wno-parentheses  -DHAVE_CONFIG_H -I.  -I.   -c -o xio-unix.o xio-unix.c     
xio-socket.c: In function 'xiocheckpeer':
xio-socket.c:1705:8: warning: unused variable 'result' [-Wunused-variable]                         
    int result;
        ^
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -D_GNU_SOURCE -Wall -Wno-parentheses  -DHAVE_CONFIG_H -I.  -I.   -c -o xio-ip.o xio-ip.c
xio-ip.c: In function 'xiolog_ancillary_ip':
xio-ip.c:520:12: error: dereferencing pointer to incomplete type
         err->ee_errno, '\0', err->ee_origin, '\0', err->ee_type, '\0',
            ^
===


Additional info:
Comment 1 Michel Normand 2015-01-14 09:45:42 UTC 
Created attachment 979922 [details]
socat_1.7.2.4_fix_linux_errqueue_h_not_found.patch

the attached patch allow to solve reported build error.
After that will need to solve bug #1107350 related to test errors.
Comment 2 Michel Normand 2015-01-14 13:19:28 UTC 
my above suggested patch is in fact a revert of http://repo.or.cz/w/socat.git/commit/8371aa3dc01cdb257303171b8a48cfd713e4a697 that has been embedded in last socat 1.7.2.4 upstream.

So in fact need a new patch that would work in all cases.
Comment 3 Michel Normand 2015-01-22 12:45:02 UTC 
Created attachment 982801 [details]
errqueue.patch
Comment 4 Michel Normand 2015-01-22 12:46:51 UTC 
(In reply to Michel Normand from comment #2)
> my above suggested patch is in fact a revert of
> http://repo.or.cz/w/socat.git/commit/
> 8371aa3dc01cdb257303171b8a48cfd713e4a697 that has been embedded in last
> socat 1.7.2.4 upstream.
> 
> So in fact need a new patch that would work in all cases.

I received the attached patch errqueue.patch from upstream maintainer
to replace mine, and the referenced scratch builds confirm that build
completed with it.

http://koji.fedoraproject.org/koji/taskinfo?taskID=8699913
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2287715
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1709923

Paul,
Could you commit this patch in fedora db ?
Comment 5 Michel Normand 2015-01-26 07:19:49 UTC 
(In reply to Michel Normand from comment #4)
> (In reply to Michel Normand from comment #2)
> > my above suggested patch is in fact a revert of
> > http://repo.or.cz/w/socat.git/commit/
> > 8371aa3dc01cdb257303171b8a48cfd713e4a697 that has been embedded in last
> > socat 1.7.2.4 upstream.
> > 
> > So in fact need a new patch that would work in all cases.
> 
> I received the attached patch errqueue.patch from upstream maintainer
> to replace mine, and the referenced scratch builds confirm that build
> completed with it.
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=8699913
> http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2287715
> http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1709923
> 
> Paul,
> Could you commit this patch in fedora db ?

in addition to above patch, my scratch build do have a spec change ignoring tests errors to bypass the other bug #1107350
===
@@ -52,7 +55,7 @@ install -m 0644 *.sh %{buildroot}/%{_docdir}/socat/
 export TERM=ansi
 export OD_C=/usr/bin/od
 # intermittently, a test sometimes just fails and hangs, mostly on arm
-timeout 30m make test
+timeout 30m make test || :
 
 %files 
 %doc BUGREPORTS CHANGES DEVELOPMENT EXAMPLES FAQ PORTING
===
Comment 6 Fedora End Of Life 2015-11-04 13:58:34 UTC 
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 7 Fedora End Of Life 2015-12-02 07:24:55 UTC 
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.
Note You need to log in before you can comment on or make changes to this bug.