Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1188763 - Review Request: nodejs-ultron - Ultron is a high-intelligence robot
Summary: Review Request: nodejs-ultron - Ultron is a high-intelligence robot
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1191708
TreeView+ depends on / blocked
 
Reported: 2015-02-03 16:30 UTC by Troy Dawson
Modified: 2015-02-25 13:31 UTC (History)
2 users (show)

Fixed In Version: nodejs-ultron-1.0.1-3.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-25 13:31:06 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Troy Dawson 2015-02-03 16:30:33 UTC 
Spec URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron.spec
SRPM URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron-1.0.1-1.fc22.src.rpm
Description: Ultron is a high-intelligence robot. It gathers intelligence
so it can start improving upon his rudimentary design.
Fedora Account System Username: tdawson
Comment 1 Troy Dawson 2015-02-03 16:32:18 UTC 
Here is a scratch build, on rawhide, if it helps.
http://koji.fedoraproject.org/koji/taskinfo?taskID=8810892
Comment 2 Parag AN(पराग) 2015-02-13 14:48:46 UTC 
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-ultron.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     : c13a9cc61bb53dc24afa50afbfeff31f31b539a005702c1a742c07001a97cd5d
upstream tarball : c13a9cc61bb53dc24afa50afbfeff31f31b539a005702c1a742c07001a97cd5d

+ License "MIT" is valid

- License text is not available

+ rest looks following packaging guidelines

Suggestions:
1) Group tag is optional and can be removed.

2) Ask upstream to provide license text. File issue upstream. Either wait for upstream to add license file or add yourself license file as Source1 in spec.
Comment 3 Troy Dawson 2015-02-13 17:53:34 UTC 
Spec URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron.spec
SRPM URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron-1.0.1-2.fc22.src.rpm

- License:
-- I have pinged upstream about providing a license file
--- https://github.com/unshiftio/ultron/issues/4
-- I have also included an MIT license file as Source1, so the review can continue.

- Group:
-- I have removed the group line
Comment 4 Parag AN(पराग) 2015-02-14 01:06:23 UTC 
Thanks. Looks good now but include the LICENSE file that upstream has committed when you import this package which includes Author name

APPROVED.
Comment 5 Troy Dawson 2015-02-16 15:14:34 UTC 
Will do.  Thanks.
Comment 6 Troy Dawson 2015-02-16 15:17:36 UTC 
New Package SCM Request
=======================
Package Name: nodejs-ultron
Short Description: Ultron is a high-intelligence robot
Upstream URL: https://github.com/unshiftio/ultron
Owners: tdawson
Branches:  f20 f21 f22 el6 epel7
InitialCC:
Comment 7 Gwyn Ciesla 2015-02-16 16:45:02 UTC 
Git done (by process-git-requests).
Comment 8 Fedora Update System 2015-02-16 19:19:40 UTC 
nodejs-ultron-1.0.1-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-ultron-1.0.1-3.fc21
Comment 9 Fedora Update System 2015-02-16 19:20:26 UTC 
nodejs-ultron-1.0.1-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-ultron-1.0.1-3.fc20
Comment 10 Fedora Update System 2015-02-17 08:01:40 UTC 
nodejs-ultron-1.0.1-3.fc21 has been pushed to the Fedora 21 testing repository.
Comment 11 Fedora Update System 2015-02-25 13:31:06 UTC 
nodejs-ultron-1.0.1-3.fc20 has been pushed to the Fedora 20 stable repository.
Comment 12 Fedora Update System 2015-02-25 13:31:22 UTC 
nodejs-ultron-1.0.1-3.fc21 has been pushed to the Fedora 21 stable repository.
Note You need to log in before you can comment on or make changes to this bug.