Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1191528 - Inconsistencies in redis-shutdown and redis-sentinel.service
Summary: Inconsistencies in redis-shutdown and redis-sentinel.service
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: redis
Version: epel7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-11 13:06 UTC by Yanis Guenane
Modified: 2015-03-28 18:37 UTC (History)
5 users (show)

Fixed In Version: redis-2.8.19-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-28 18:37:26 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Yanis Guenane 2015-02-11 13:06:45 UTC 
Description of problem:

The redis-shutdown bin relies on $2 when (based on the redis-sentinel.service) it should rely on the $1 to find the proper service name. $2 is always empty, hence it default to redis and kills the redis process.

Also the ExecStop= passes 'sentinel', when based on the content of redis-shutdown it should passe redis-sentinel (for the configuration file for example)

Version-Release number of selected component (if applicable):

redis-2.8.14-2.el7.x86_64
epel-release-7-5.noarch

How reproducible:

Always

Steps to Reproduce:
1. Install redis
2. Run systemctl start redis-sentinel

Actual results:

It stops the redis process (not the sentinel one)

Expected results:

redis-sentinel up and running

Additional info:
Comment 1 Haïkel Guémar 2015-02-11 13:11:11 UTC 
I'll take a look.
Comment 3 Yanis Guenane 2015-02-12 08:26:16 UTC 
Also, the default redis port in /usr/bin/redis-shutown should be 6379 instead of 6279[1]

[1] https://github.com/antirez/redis/blob/e6416ca71cd7c55d8cddd0e1596fd989e24988d9/redis.conf#L54-L56
Comment 4 Yanis Guenane 2015-02-12 08:27:08 UTC 
On the initial step to reproduce I mean systemctl stop redis-sentinel instead of start.
Comment 5 Haïkel Guémar 2015-02-27 13:38:43 UTC 
Fixed in current release
Comment 6 Haïkel Guémar 2015-02-27 13:55:07 UTC 
Reopened, the 2.8.18 update was never sent, 2.8.19 is coming today.
Comment 7 Fedora Update System 2015-02-27 20:33:19 UTC 
redis-2.8.19-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/redis-2.8.19-1.el7
Comment 8 Fedora Update System 2015-02-28 17:57:55 UTC 
Package redis-2.8.19-1.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing redis-2.8.19-1.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-1013/redis-2.8.19-1.el7
then log in and leave karma (feedback).
Comment 9 Fedora Update System 2015-03-28 18:37:26 UTC 
redis-2.8.19-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.