> Summary:        A simple one level options merge utility

This is a pretty bad summary; there's no way a user would be able to tell if 
they need this or not. It's also not an utility, its a library.

> Group:          Development/Languages/Other

No souch group exist. Please drop the tag altogether or pick a suitable
library from /usr/share/doc/rpm/GROUPS

> BuildRoot:      %{_tmppath}/%{pkg_name}-%{version}-build

Not needed anymore unless you're building for el5.

> ExclusiveArch:  %{ix86} x86_64 %{arm} noarch

You can use %{nodejs_arches}, unless you're building for el5.

> #%{nodejs_find_provides_and_requires}

This doesn't look right, is that intentional? Note that macro expansion happens 
before parsing comments.

> %description
> Merge single level defaults over a config object.

This needs improvement, it seems to make very little sense.

> %prep
> %setup -q -n package
> %build

Please keep spacing consistent (add a line break before %build).

> %defattr(-,root,root,-)

Not needed for post-el5.

* Package named properly
* Version correct
- License?
  How can you tell it's MIT? There's no license text included altogether and MIT
  license specifically requires the source to be distributed with the copy of
  the license. Please contact upstream and ask them to fix the issue.
* Builds fine in mock
* Filelist sane
* Requires sane
* Provides sane
- rpmlint unhappy
  Essentially complains about what has been pointed out above

Also, there seems to be a test included, but the package lacks a %check section. Please add it.

Spec URL: 
SRPM URL:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-defaults/nodejs-defaults.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-defaults/nodejs-defaults-1.0.0-3.fc23.src.rpm

Looks better. A couple of minor issues:

1.) Please don't use too long lines in changelogs; they are difficult to use.

Also, you need to escape "%", otherwise it causes a macro expansion. Everywhere.

Changelog entry like this would probably be better:

* Tue Mar 17 2015 Zuzana Svetlikova <zsvetlik> - 1.0.0-3
- Added %%check, %%license, nodejs-clone dependency
- changed ExclusiveArch
- removed Group, BuildRoot and %%defattr
- fixed dependency on nodejs-packaging

2.) Why are the tests conditional?

It sometimes makes sense to disable the tests by default when the dependencies are not satisfied yet, but not here.

Please drop the %enable_tests macro.

These seem to be fairly minor and uncontroversial issues, fine to fix them post-import.

APPROVED

New Package SCM Request
=======================
Package Name: nodejs-defaults
Short Description: A simple one level options merge utility
Upstream URL: https://github.com/tmpvar/defaults
Owners: zvetlik humaton
Branches: f20 f21 f22 el6
InitialCC: humaton

The maintainer cancelled the review approval, presumably by accident. Setting back to +.

Zuzana: you probably meant to set fedora‑cvs=?. Please do that.

Yes, my mistake, sorry.

Git done (by process-git-requests).

What's the status of this?

Has the package been imported?

Seems like it's built into f23.

nodejs-defaults-1.0.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-defaults-1.0.2-2.fc20

nodejs-defaults-1.0.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-defaults-1.0.2-2.fc21

nodejs-defaults-1.0.2-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-defaults-1.0.2-2.fc22

nodejs-defaults-1.0.2-2.fc22 has been pushed to the Fedora 22 stable repository.

nodejs-defaults-1.0.2-2.fc20 has been pushed to the Fedora 20 stable repository.

nodejs-defaults-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository.