Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1199199 - Review request: nodejs-char-spinner - Node.js char spinner
Summary: Review request: nodejs-char-spinner - Node.js char spinner
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Piotr Popieluch
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
Reported: 2015-03-05 15:46 UTC by Zuzana Svetlikova
Modified: 2015-09-02 17:37 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1221183 (view as bug list)
Last Closed: 2015-09-02 17:37:35 UTC
Type: Bug
piotr1212: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Zuzana Svetlikova 2015-03-05 15:46:03 UTC
Spec URL:
Description: Put a little spinner on process.stderr, as unobtrusively as possible.
Fedora Account System Username: zvetlik

Comment 1 Piotr Popieluch 2015-03-08 20:26:04 UTC
- please remove scl prefixes
- remove group unless you intend to package for el5
- remove buildroot:
- add: ExclusiveArch: %{nodejs_arches} noarch for newer fedora's
- remove defattr
- move license from %doc to %license
- please add tests

Comment 3 Piotr Popieluch 2015-03-20 22:14:23 UTC

Please fix following issues before importing:
- Relase number differs from release number in changelog, please change release number
- specfile differs from srpm, rebuild srpm before importing to SCM

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 2 files have unknown license. Detailed output of
     licensecheck in /home/piotr/rpmbuild/1199199-nodejs-char-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: nodejs-char-spinner-1.0.1-4.fc23.noarch.rpm
nodejs-char-spinner.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-char-spinner.noarch: W: spelling-error %description -l en_US stderr -> std err, std-err, stander
nodejs-char-spinner.noarch: W: incoherent-version-in-changelog 1.0.1-3 ['1.0.1-4.fc23', '1.0.1-4']
nodejs-char-spinner.noarch: W: only-non-binary-in-usr-lib
nodejs-char-spinner.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-char-spinner.src: W: spelling-error %description -l en_US stderr -> std err, std-err, stander
nodejs-char-spinner.src:46: W: macro-in-%changelog %nodejs_symlink_deps
nodejs-char-spinner.src:46: W: macro-in-%changelog %check
nodejs-char-spinner.src:46: W: macro-in-%changelog %license
nodejs-char-spinner.src:46: W: macro-in-%changelog %nodejs_find_and_provides
nodejs-char-spinner.src:46: W: macro-in-%changelog %defattr
2 packages and 0 specfiles checked; 0 errors, 11 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:

Diff spec file in url and in SRPM
--- /home/piotr/rpmbuild/1199199-nodejs-char-spinner/srpm/nodejs-char-spinner.spec	2015-03-20 22:46:18.371853858 +0100
+++ /home/piotr/rpmbuild/1199199-nodejs-char-spinner/srpm-unpacked/nodejs-char-spinner.spec	2015-03-11 14:51:13.000000000 +0100
@@ -3,20 +3,16 @@
-%global enable_tests 1
+%global enable_tests 0
-Name:		%{?scl_prefix}nodejs-char-spinner
-Version:	1.0.1
-Release:	4%{?dist}
-Summary:	Node.js char spinner
-License:	ISC
-BuildRequires:	nodejs-packaging
-BuildArch:	noarch
-ExclusiveArch:	%{nodejs_arches} noarch
-%if 0%{?enable_tests}
-BuildRequires:	npm(tap)
+Name:           %{?scl_prefix}nodejs-char-spinner
+Version:        1.0.1
+Release:        4%{?dist}
+Summary:        Node.js char spinner
+License:        ISC
+BuildRequires:  nodejs-packaging
+BuildArch:      noarch
+ExclusiveArch:  %{nodejs_arches} noarch
@@ -31,5 +27,5 @@
 mkdir -p %{buildroot}%{nodejs_sitelib}/char-spinner
 cp -pr package.json spin.js \
-	%{buildroot}%{nodejs_sitelib}/char-spinner
+        %{buildroot}%{nodejs_sitelib}/char-spinner
@@ -48,9 +44,5 @@
 * Tue Mar 10 2015 Zuzana Svetlikova <zsvetlik> - 1.0.1-3
-- Fixed dependency on nodejs-packaging
-- added %%nodejs_symlink_deps, %%check and %%license
-- changed ExclusiveArch and %%nodejs_find_and_provides
-- removed Group, BuildRoot and %%defattr
+- Fixed dependency on nodejs-packaging, added %nodejs_symlink_deps, %check and %license, changed ExclusiveArch and %nodejs_find_and_provides, removed Group, BuildRoot and %defattr
 * Tue Jan 13 2015 Tomas Hrcka <thrcka> - 1.0.1-2

nodejs-char-spinner (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 2c34b69bf46751e7c30f93fe079d319addec7568185d2bce02987767d3193cf0
  CHECKSUM(SHA256) upstream package : 2c34b69bf46751e7c30f93fe079d319addec7568185d2bce02987767d3193cf0

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1199199
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 4 Zuzana Svetlikova 2015-03-21 01:13:27 UTC
New sources with fixed issues:

Spec URL:

I don't quite understand why there is the Issues section, the license text is included in the srpm.

Comment 5 Piotr Popieluch 2015-03-21 10:33:34 UTC
Please ignore the license notice in the Issue section. The %license directive in %doc is new, fedora-review on F21 is not updated yet to support that.

Package looks good.

Comment 6 Zuzana Svetlikova 2015-03-21 10:58:03 UTC
New Package SCM Request
Package Name: nodejs-char-spinner
Short Description: Node.js char spinner
Upstream URL:
Owners: zvetlik humaton
Branches: f20 f21 f22
InitialCC: humaton

Comment 7 Gwyn Ciesla 2015-03-21 16:43:40 UTC
Git done (by process-git-requests).

Comment 8 Piotr Popieluch 2015-05-22 18:36:52 UTC
You can close the bug when you have built the package, then you don't need to "unblock" other bugs. 
When you create an update in bodhi the bug will get closed automatically when pushed to stable repo (You can create updates with fedpkg-update or from the webinterface )

Comment 9 Zuzana Svetlikova 2015-06-23 13:28:23 UTC
New Package SCM Request
Package Name: nodejs-char-spinner
Short Description: Node.js char spinner
Upstream URL:
Owners: zvetlik
Branches: el6 epel7

Comment 10 Gwyn Ciesla 2015-06-23 17:35:35 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.