1217918 – sync Modify.InstallPackageNames returnes immediately, does nothing

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1217918 - sync Modify.InstallPackageNames returnes immediately, does nothing

Summary: sync Modify.InstallPackageNames returnes immediately, does nothing

Keywords:
Status:	CLOSED NOTABUG
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	gnome-software
Sub Component:
Version:	26
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Richard Hughes
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-05-02 22:21 UTC by Cole Robinson
Modified:	2017-08-07 22:31 UTC (History)
CC List:	3 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2017-08-07 22:31:11 UTC
Type:	Bug
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Description Cole Robinson 2015-05-02 22:21:53 UTC

virt-manager wants to check for a few libvirt packages at start up, and offer to install them if needed. However on latest f22, InstallPackageNames just returns immediately for us and doesn't do anything.

Here's the code:

def packagekit_install(parent, package_list):
    bus = Gio.bus_get_sync(Gio.BusType.SESSION, None)
    pk_control = Gio.DBusProxy.new_sync(bus, 0, None,
                            "org.freedesktop.PackageKit",
                            "/org/freedesktop/PackageKit",
                            "org.freedesktop.PackageKit.Modify", None)

    xid = 0
    try:
        # Need to import GdkX11 just to get access to get_xid function
        # This will likely fail on wayland in the future, so ignore errors
        from gi.repository import GdkX11  # pylint: disable=no-name-in-module
        ignore = GdkX11

        if parent and parent.topwin.get_window():
            xid = parent.topwin.get_window().get_xid()
    except:
        pass

    # Set 2 hour timeout
    timeout = 1000 * 60 * 60 * 2
    logging.debug("Installing packages: %s", package_list)
    pk_control.InstallPackageNames("(uass)", xid, package_list, "")
    logging.debug("Install completed")



Before this we call Query.IsInstalled, so gnome-software definitely doesn't think the packages are installed.

Running /usr/bin/gnome-software --gapplication-service --verbose   I see the 3 IsInstalled calls, then the InstallPackageNames call, but nothing after it:

(org.gnome.Software:5100): Gs-DEBUG: ****** IsInstalled
(org.gnome.Software:5100): PackageKit-DEBUG: role now resolve
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): Gs-DEBUG: ****** IsInstalled
(org.gnome.Software:5100): PackageKit-DEBUG: role now resolve
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): Gs-DEBUG: ****** IsInstalled
(org.gnome.Software:5100): PackageKit-DEBUG: role now resolve
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): PackageKit-DEBUG: emit transaction-list-changed
(org.gnome.Software:5100): Gs-DEBUG: ****** Modify.InstallPackageNames

Comment 1 Fedora Update System 2015-05-13 22:30:49 UTC

adwaita-icon-theme-3.16.2.1-1.fc22,aisleriot-3.16.2-1.fc22,bijiben-3.16.2-1.fc22,clutter-1.22.2-1.fc22,control-center-3.16.2-1.fc22,empathy-3.12.10-2.fc22,eog-3.16.2-1.fc22,epiphany-3.16.1-1.fc22,evince-3.16.0-2.fc22,evolution-3.16.2.1-1.fc22,evolution-data-server-3.16.2-2.fc22,evolution-ews-3.16.2-1.fc22,evolution-mapi-3.16.2-1.fc22,file-roller-3.16.2-1.fc22,four-in-a-row-3.16.2-1.fc22,gcr-3.16.0-1.fc22,gdk-pixbuf2-2.31.4-1.fc22,geocode-glib-3.16.2-1.fc22,glib2-2.44.1-1.fc22,gnome-boxes-3.16.2-1.fc22,gnome-calendar-3.16.2-1.fc22,gnome-characters-3.16.2-1.fc22,gnome-chess-3.16.2-1.fc22,gnome-desktop3-3.16.2-1.fc22,gnome-devel-docs-3.16.2-1.fc22,gnome-dictionary-3.16.2-1.fc22,gnome-disk-utility-3.16.1-1.fc22,gnome-documents-3.16.2-1.fc22,gnome-font-viewer-3.16.2-1.fc22,gnome-getting-started-docs-3.16.2-1.fc22,gnome-initial-setup-3.16.2-1.fc22,gnome-logs-3.16.2-1.fc22,gnome-mahjongg-3.16.1-1.fc22,gnome-maps-3.16.2-1.fc22,gnome-online-accounts-3.16.2-1.fc22,gnome-online-miners-3.14.3-1.fc22,gnome-photos-3.16.2-1.fc22,gnome-power-manager-3.16.1-2.fc22,gnome-screenshot-3.16.2-1.fc22,gnome-settings-daemon-3.16.2-1.fc22,gnome-software-3.16.2-1.fc22,gnome-terminal-3.16.2-1.fc22,gnome-themes-standard-3.16.2-1.fc22,gnome-tweak-tool-3.16.2-1.fc22,gtk-doc-1.22-1.fc22,gtk2-2.24.28-1.fc22,gtk3-3.16.3-1.fc22,gucharmap-3.16.2-1.fc22,gupnp-0.20.14-1.fc22,gupnp-tools-0.8.10-1.fc22,nautilus-3.16.2-1.fc22,orca-3.16.2-1.fc22,quadrapassel-3.16.1-1.fc22,rygel-0.26.1-1.fc22,seahorse-3.16.0-1.fc22,simple-scan-3.16.2-1.fc22,sushi-3.16.0-1.fc22,tali-3.16.1-1.fc22,vinagre-3.16.1-1.fc22,vte291-0.40.2-1.fc22,yelp-3.16.1-1.fc22,zenity-3.16.0-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/adwaita-icon-theme-3.16.2.1-1.fc22,aisleriot-3.16.2-1.fc22,bijiben-3.16.2-1.fc22,clutter-1.22.2-1.fc22,control-center-3.16.2-1.fc22,empathy-3.12.10-2.fc22,eog-3.16.2-1.fc22,epiphany-3.16.1-1.fc22,evince-3.16.0-2.fc22,evolution-3.16.2.1-1.fc22,evolution-data-server-3.16.2-2.fc22,evolution-ews-3.16.2-1.fc22,evolution-mapi-3.16.2-1.fc22,file-roller-3.16.2-1.fc22,four-in-a-row-3.16.2-1.fc22,gcr-3.16.0-1.fc22,gdk-pixbuf2-2.31.4-1.fc22,geocode-glib-3.16.2-1.fc22,glib2-2.44.1-1.fc22,gnome-boxes-3.16.2-1.fc22,gnome-calendar-3.16.2-1.fc22,gnome-characters-3.16.2-1.fc22,gnome-chess-3.16.2-1.fc22,gnome-desktop3-3.16.2-1.fc22,gnome-devel-docs-3.16.2-1.fc22,gnome-dictionary-3.16.2-1.fc22,gnome-disk-utility-3.16.1-1.fc22,gnome-documents-3.16.2-1.fc22,gnome-font-viewer-3.16.2-1.fc22,gnome-getting-started-docs-3.16.2-1.fc22,gnome-initial-setup-3.16.2-1.fc22,gnome-logs-3.16.2-1.fc22,gnome-mahjongg-3.16.1-1.fc22,gnome-maps-3.16.2-1.fc22,gnome-online-accounts-3.16.2-1.fc22,gnome-online-miners-3.14.3-1.fc22,gnome-photos-3.16.2-1.fc22,gnome-power-manager-3.16.1-2.fc22,gnome-screenshot-3.16.2-1.fc22,gnome-settings-daemon-3.16.2-1.fc22,gnome-software-3.16.2-1.fc22,gnome-terminal-3.16.2-1.fc22,gnome-themes-standard-3.16.2-1.fc22,gnome-tweak-tool-3.16.2-1.fc22,gtk-doc-1.22-1.fc22,gtk2-2.24.28-1.fc22,gtk3-3.16.3-1.fc22,gucharmap-3.16.2-1.fc22,gupnp-0.20.14-1.fc22,gupnp-tools-0.8.10-1.fc22,nautilus-3.16.2-1.fc22,orca-3.16.2-1.fc22,quadrapassel-3.16.1-1.fc22,rygel-0.26.1-1.fc22,seahorse-3.16.0-1.fc22,simple-scan-3.16.2-1.fc22,sushi-3.16.0-1.fc22,tali-3.16.1-1.fc22,vinagre-3.16.1-1.fc22,vte291-0.40.2-1.fc22,yelp-3.16.1-1.fc22,zenity-3.16.0-1.fc22

Comment 2 Fedora Update System 2015-05-14 22:21:25 UTC

Package adwaita-icon-theme-3.16.2.1-1.fc22, aisleriot-3.16.2-1.fc22, bijiben-3.16.2-1.fc22, clutter-1.22.2-1.fc22, control-center-3.16.2-1.fc22, empathy-3.12.10-2.fc22, eog-3.16.2-1.fc22, epiphany-3.16.1-1.fc22, evince-3.16.0-2.fc22, evolution-3.16.2.1-1.fc22, evolution-data-server-3.16.2-2.fc22, evolution-ews-3.16.2-1.fc22, evolution-mapi-3.16.2-1.fc22, file-roller-3.16.2-1.fc22, four-in-a-row-3.16.2-1.fc22, gcr-3.16.0-1.fc22, gdk-pixbuf2-2.31.4-1.fc22, geocode-glib-3.16.2-1.fc22, glib2-2.44.1-1.fc22, gnome-boxes-3.16.2-1.fc22, gnome-calendar-3.16.2-1.fc22, gnome-characters-3.16.2-1.fc22, gnome-chess-3.16.2-1.fc22, gnome-desktop3-3.16.2-1.fc22, gnome-devel-docs-3.16.2-1.fc22, gnome-dictionary-3.16.2-1.fc22, gnome-disk-utility-3.16.1-1.fc22, gnome-documents-3.16.2-1.fc22, gnome-font-viewer-3.16.2-1.fc22, gnome-getting-started-docs-3.16.2-1.fc22, gnome-initial-setup-3.16.2-1.fc22, gnome-logs-3.16.2-1.fc22, gnome-mahjongg-3.16.1-1.fc22, gnome-maps-3.16.2-1.fc22, gnome-online-accounts-3.16.2-1.fc22, gnome-online-miners-3.14.3-1.fc22, gnome-photos-3.16.2-1.fc22, gnome-power-manager-3.16.1-2.fc22, gnome-screenshot-3.16.2-1.fc22, gnome-settings-daemon-3.16.2-1.fc22, gnome-software-3.16.2-1.fc22, gnome-terminal-3.16.2-1.fc22, gnome-themes-standard-3.16.2-1.fc22, gnome-tweak-tool-3.16.2-1.fc22, gtk-doc-1.22-1.fc22, gtk2-2.24.28-1.fc22, gtk3-3.16.3-1.fc22, gucharmap-3.16.2-1.fc22, gupnp-0.20.14-1.fc22, gupnp-tools-0.8.10-1.fc22, nautilus-3.16.2-1.fc22, orca-3.16.2-1.fc22, quadrapassel-3.16.1-1.fc22, rygel-0.26.1-1.fc22, seahorse-3.16.0-1.fc22, simple-scan-3.16.2-1.fc22, sushi-3.16.0-1.fc22, tali-3.16.1-1.fc22, vinagre-3.16.1-1.fc22, vte291-0.40.2-1.fc22, yelp-3.16.1-1.fc22, zenity-3.16.0-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing adwaita-icon-theme-3.16.2.1-1.fc22 aisleriot-3.16.2-1.fc22 bijiben-3.16.2-1.fc22 clutter-1.22.2-1.fc22 control-center-3.16.2-1.fc22 empathy-3.12.10-2.fc22 eog-3.16.2-1.fc22 epiphany-3.16.1-1.fc22 evince-3.16.0-2.fc22 evolution-3.16.2.1-1.fc22 evolution-data-server-3.16.2-2.fc22 evolution-ews-3.16.2-1.fc22 evolution-mapi-3.16.2-1.fc22 file-roller-3.16.2-1.fc22 four-in-a-row-3.16.2-1.fc22 gcr-3.16.0-1.fc22 gdk-pixbuf2-2.31.4-1.fc22 geocode-glib-3.16.2-1.fc22 glib2-2.44.1-1.fc22 gnome-boxes-3.16.2-1.fc22 gnome-calendar-3.16.2-1.fc22 gnome-characters-3.16.2-1.fc22 gnome-chess-3.16.2-1.fc22 gnome-desktop3-3.16.2-1.fc22 gnome-devel-docs-3.16.2-1.fc22 gnome-dictionary-3.16.2-1.fc22 gnome-disk-utility-3.16.1-1.fc22 gnome-documents-3.16.2-1.fc22 gnome-font-viewer-3.16.2-1.fc22 gnome-getting-started-docs-3.16.2-1.fc22 gnome-initial-setup-3.16.2-1.fc22 gnome-logs-3.16.2-1.fc22 gnome-mahjongg-3.16.1-1.fc22 gnome-maps-3.16.2-1.fc22 gnome-online-accounts-3.16.2-1.fc22 gnome-online-miners-3.14.3-1.fc22 gnome-photos-3.16.2-1.fc22 gnome-power-manager-3.16.1-2.fc22 gnome-screenshot-3.16.2-1.fc22 gnome-settings-daemon-3.16.2-1.fc22 gnome-software-3.16.2-1.fc22 gnome-terminal-3.16.2-1.fc22 gnome-themes-standard-3.16.2-1.fc22 gnome-tweak-tool-3.16.2-1.fc22 gtk-doc-1.22-1.fc22 gtk2-2.24.28-1.fc22 gtk3-3.16.3-1.fc22 gucharmap-3.16.2-1.fc22 gupnp-0.20.14-1.fc22 gupnp-tools-0.8.10-1.fc22 nautilus-3.16.2-1.fc22 orca-3.16.2-1.fc22 quadrapassel-3.16.1-1.fc22 rygel-0.26.1-1.fc22 seahorse-3.16.0-1.fc22 simple-scan-3.16.2-1.fc22 sushi-3.16.0-1.fc22 tali-3.16.1-1.fc22 vinagre-3.16.1-1.fc22 vte291-0.40.2-1.fc22 yelp-3.16.1-1.fc22 zenity-3.16.0-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-8219/adwaita-icon-theme-3.16.2.1-1.fc22,aisleriot-3.16.2-1.fc22,bijiben-3.16.2-1.fc22,clutter-1.22.2-1.fc22,control-center-3.16.2-1.fc22,empathy-3.12.10-2.fc22,eog-3.16.2-1.fc22,epiphany-3.16.1-1.fc22,evince-3.16.0-2.fc22,evolution-3.16.2.1-1.fc22,evolution-data-server-3.16.2-2.fc22,evolution-ews-3.16.2-1.fc22,evolution-mapi-3.16.2-1.fc22,file-roller-3.16.2-1.fc22,four-in-a-row-3.16.2-1.fc22,gcr-3.16.0-1.fc22,gdk-pixbuf2-2.31.4-1.fc22,geocode-glib-3.16.2-1.fc22,glib2-2.44.1-1.fc22,gnome-boxes-3.16.2-1.fc22,gnome-calendar-3.16.2-1.fc22,gnome-characters-3.16.2-1.fc22,gnome-chess-3.16.2-1.fc22,gnome-desktop3-3.16.2-1.fc22,gnome-devel-docs-3.16.2-1.fc22,gnome-dictionary-3.16.2-1.fc22,gnome-disk-utility-3.16.1-1.fc22,gnome-documents-3.16.2-1.fc22,gnome-font-viewer-3.16.2-1.fc22,gnome-getting-started-docs-3.16.2-1.fc22,gnome-initial-setup-3.16.2-1.fc22,gnome-logs-3.16.2-1.fc22,gnome-mahjongg-3.16.1-1.fc22,gnome-maps-3.16.2-1.fc22,gnome-online-accounts-3.16.2-1.fc22,gnome-online-miners-3.14.3-1.fc22,gnome-photos-3.16.2-1.fc22,gnome-power-manager-3.16.1-2.fc22,gnome-screenshot-3.16.2-1.fc22,gnome-settings-daemon-3.16.2-1.fc22,gnome-software-3.16.2-1.fc22,gnome-terminal-3.16.2-1.fc22,gnome-themes-standard-3.16.2-1.fc22,gnome-tweak-tool-3.16.2-1.fc22,gtk-doc-1.22-1.fc22,gtk2-2.24.28-1.fc22,gtk3-3.16.3-1.fc22,gucharmap-3.16.2-1.fc22,gupnp-0.20.14-1.fc22,gupnp-tools-0.8.10-1.fc22,nautilus-3.16.2-1.fc22,orca-3.16.2-1.fc22,quadrapassel-3.16.1-1.fc22,rygel-0.26.1-1.fc22,seahorse-3.16.0-1.fc22,simple-scan-3.16.2-1.fc22,sushi-3.16.0-1.fc22,tali-3.16.1-1.fc22,vinagre-3.16.1-1.fc22,vte291-0.40.2-1.fc22,yelp-3.16.1-1.fc22,zenity-3.16.0-1.fc22
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2015-05-18 23:57:41 UTC

adwaita-icon-theme-3.16.2.1-1.fc22, aisleriot-3.16.2-1.fc22, bijiben-3.16.2-1.fc22, clutter-1.22.2-1.fc22, control-center-3.16.2-1.fc22, empathy-3.12.10-2.fc22, eog-3.16.2-1.fc22, epiphany-3.16.1-1.fc22, evince-3.16.0-2.fc22, evolution-3.16.2.1-1.fc22, evolution-data-server-3.16.2-2.fc22, evolution-ews-3.16.2-1.fc22, evolution-mapi-3.16.2-1.fc22, file-roller-3.16.2-1.fc22, four-in-a-row-3.16.2-1.fc22, gcr-3.16.0-1.fc22, gdk-pixbuf2-2.31.4-1.fc22, geocode-glib-3.16.2-1.fc22, glib2-2.44.1-1.fc22, gnome-boxes-3.16.2-1.fc22, gnome-calendar-3.16.2-1.fc22, gnome-characters-3.16.2-1.fc22, gnome-chess-3.16.2-1.fc22, gnome-desktop3-3.16.2-1.fc22, gnome-devel-docs-3.16.2-1.fc22, gnome-dictionary-3.16.2-1.fc22, gnome-disk-utility-3.16.1-1.fc22, gnome-documents-3.16.2-1.fc22, gnome-font-viewer-3.16.2-1.fc22, gnome-getting-started-docs-3.16.2-1.fc22, gnome-initial-setup-3.16.2-1.fc22, gnome-logs-3.16.2-1.fc22, gnome-mahjongg-3.16.1-1.fc22, gnome-maps-3.16.2-1.fc22, gnome-online-accounts-3.16.2-1.fc22, gnome-online-miners-3.14.3-1.fc22, gnome-photos-3.16.2-1.fc22, gnome-power-manager-3.16.1-2.fc22, gnome-screenshot-3.16.2-1.fc22, gnome-settings-daemon-3.16.2-1.fc22, gnome-software-3.16.2-1.fc22, gnome-terminal-3.16.2-1.fc22, gnome-themes-standard-3.16.2-1.fc22, gnome-tweak-tool-3.16.2-1.fc22, gtk-doc-1.22-1.fc22, gtk2-2.24.28-1.fc22, gtk3-3.16.3-1.fc22, gucharmap-3.16.2-1.fc22, gupnp-0.20.14-1.fc22, gupnp-tools-0.8.10-1.fc22, nautilus-3.16.2-1.fc22, orca-3.16.2-1.fc22, quadrapassel-3.16.1-1.fc22, rygel-0.26.1-1.fc22, seahorse-3.16.0-1.fc22, simple-scan-3.16.2-1.fc22, sushi-3.16.0-1.fc22, tali-3.16.1-1.fc22, vinagre-3.16.1-1.fc22, vte291-0.40.2-1.fc22, yelp-3.16.1-1.fc22, zenity-3.16.0-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 4 Cole Robinson 2016-08-10 14:22:02 UTC

Note, I don't think this was ever fixed, I just never followed up. gnome-software's implementation of InstallPackageNames doesn't seem to be functional. For example, try the official example here:

https://www.freedesktop.org/software/PackageKit/files/session.py

Even if I change the package list to ["kolourpaint"], an app I know has an appdata file and that I don't have installed, the InstallPackageNames call returns immediately and the script exits with no visible result. The same script still works fine with KDE apper at least

Am I missing something, or is gnome-software's impl of InstallPackageNames busted?

Comment 5 Cole Robinson 2017-06-07 18:32:20 UTC

Still seems to be the case on fedora 26.

I feel like I'm missing something simple... Richard, do you know what's going on here?

Comment 6 Cole Robinson 2017-08-07 22:31:11 UTC

I know what's happening now. gnome-software does not work like gnome-packagekit or apper here, and instead of synchronously installing a requested package and blocking the caller until its complete, just sends a desktop notification saying 'someone wants to install software' and returns.

Pretty major semantic change IMO from long standing way this worked for the session interface providers, I'm sure many if not all callers of InstallPackageNames need/needed changing to handle it. Makes my life as an app writer harder at least. Ah well :/

Anyways the reason why I wasn't seeing anything is because I had disabled gnome-software notifications on my dev machine for other reasons. So since everything is likely working as expected here I'll close this

Note You need to log in before you can comment on or make changes to this bug.