Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1224187 - binutils FTBFS during stage1 bootstrap - logical not is only applied to the left hand side of comparison
Summary: binutils FTBFS during stage1 bootstrap - logical not is only applied to the l...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: binutils
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-bootstrap
TreeView+ depends on / blocked
 
Reported: 2015-05-22 10:11 UTC by Jaromír Cápík
Modified: 2016-02-01 02:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-11 15:17:33 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
binutils.log (242.62 KB, text/plain)
2015-05-22 10:11 UTC, Jaromír Cápík 		no flags Details
binutils-2.24-i386-logical-not.patch (573 bytes, text/plain)
2015-05-22 10:13 UTC, Jaromír Cápík 		no flags Details
View All

Description Jaromír Cápík 2015-05-22 10:11:45 UTC 
Created attachment 1028679 [details]
binutils.log

Description of problem:
During stage1 bootstrap we experience FTBFS caused by unsupported evaluation.

----
gcc -DHAVE_CONFIG_H -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas  -I. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas -I../bfd -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../include -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/.. -I/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/../bfd -DLOCALEDIR="\"/home/fedora-bootstrap/install/share/locale\""  -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT atof-ieee.o -MD -MP -MF .deps/atof-ieee.Tpo -c -o atof-ieee.o `test -f 'config/atof-ieee.c' || echo '/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/'`config/atof-ieee.c
/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c: In function 'build_modrm_byte':
/home/fedora-bootstrap/rpmbuild/BUILD/binutils-2.24/gas/config/tc-i386.c:6143:31: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
         && !op.bitfield.reg64 != 1
                               ^
----

Tha attached patch fixes that.

Version-Release number of selected component (if applicable):
binutils-2.24-30.fc21

How reproducible:
always
Comment 1 Jaromír Cápík 2015-05-22 10:13:05 UTC 
Created attachment 1028680 [details]
binutils-2.24-i386-logical-not.patch
Comment 2 Marek Polacek 2015-05-22 10:21:07 UTC 
I think you want a different patch, I think you'll want to backport 
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=ac4eb736520174305bf6e691827f7473b858cff1;hp=ae6c7e33e1510665e8e043eb11a71e59414efbf3
Comment 3 Jaromír Cápík 2015-05-22 11:00:38 UTC 
Ahoj Marku.

I only fixed the FTBFS. The patch from Alan Modra is a superset of my fix and should do the same job. However the Alan's code looks cleaner, so ... I'm ok with backport :]
Comment 4 Nick Clifton 2015-05-28 12:41:36 UTC 
Hi Guys,

I have added Alan's patch to the F21 sources (binutils-2.24-32.fc21.src.rpm).  The patch is not needed for F22 or later as the change is already in the binutils tarball.

Cheers
  Nick
Comment 5 Jaromír Cápík 2015-05-28 13:04:48 UTC 
Hello Nick.
Would you mind building it + pushing to testing? You don't need to push it to stable. Our builders pull stuff from updates-testing.
Thanks,
Jaromir.
Comment 6 Nick Clifton 2015-05-28 13:23:55 UTC 
Hi Jaromir,

  Done... :-)

Cheers
  Nick
Comment 7 Jaromír Cápík 2015-06-11 15:17:33 UTC 
Hi Nick. I believe we can close this one. Thanks, Jaromir.
Note You need to log in before you can comment on or make changes to this bug.