Questions and suggestion
========================

What is the relation to ignition_math2? Does it supersede this version?

%check is present, but the result is ignored. Is there a reason to ignore the result?

I suggest using %global _docdir_fmt %{name}.


Package Review
==============

Legend:
[x] = Pass, [-] = Not applicable, [?] = question

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
ASL 2.

[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "BSD (3 clause)", "Unknown or generated". 6
     files have unknown license. Detailed output of licensecheck in
     /var/tmp/1224390-ignition-math/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
-devel requires the main package.

[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/lib64/pkgconfig(pkgconfig), /usr/lib64/cmake(pulseaudio-libs-
     devel, phonon-devel, cmake, qt5-qtlocation, qt5-qtbase)
OK.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     ignition-math-doc
[x]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ignition-math-1.0.0-1.fc23.x86_64.rpm
          ignition-math-devel-1.0.0-1.fc23.x86_64.rpm
          ignition-math-doc-1.0.0-1.fc23.noarch.rpm
          ignition-math-1.0.0-1.fc23.src.rpm
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
ignition-math.src: W: strange-permission ignition-math-1.0.0.tar.bz2 0400L
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

OK.


Rpmlint (debuginfo)
-------------------
Checking: ignition-math-debuginfo-1.0.0-1.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
ignition-math.x86_64: W: private-shared-object-provides /usr/lib64/libignition-math.so.1.0.0 libignition-math.so.1()(64bit)
I think this is OK...

ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Requires
--------
ignition-math (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ignition-math-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    ignition-math(x86-64)
    libignition-math.so.1()(64bit)

ignition-math-doc (rpmlib, GLIBC filtered):

Provides
--------
ignition-math:
    ignition-math
    ignition-math(x86-64)
    libignition-math.so.1()(64bit)

ignition-math-devel:
    cmake(ignition-math)
    ignition-math-devel
    ignition-math-devel(x86-64)
    pkgconfig(ignition-math)

ignition-math-doc:
    ignition-math-doc

Source checksums
----------------
http://gazebosim.org/distributions/ign-math/releases/ignition-math-1.0.0.tar.bz2 :
  CHECKSUM(SHA256) this package     : 5c15bbafdab35d1e0b2f9e43ea13fc665e29c19530c94c89b92a86491128b30a
  CHECKSUM(SHA256) upstream package : 5c15bbafdab35d1e0b2f9e43ea13fc665e29c19530c94c89b92a86491128b30a


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1224390
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Thanks.  The unit tests were disabled because one of them was failing on i686.  I'm working with upstream to get a fix in place, and will have an updated package once that's done.

> What is the relation to ignition_math2? Does it supersede this version?
Yes, it does supersede this version. Upstream adds the major version to the tarball name, but it's the same project.  I've updated the spec to the 2.2.2 release of ignition-math.

> %check is present, but the result is ignored. Is there a reason to ignore the result?
A test was failing on i686.  I've included a patch that fixes the failing unit test.  I've also updated the spec to fail when unit tests fail, after printing out the failure log.

> I suggest using %global _docdir_fmt %{name}.
Good call, added.

Updated spec and SRPM can be found at:

Spec URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math.spec
SRPM URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math-2.2.2-1.fc22.src.rpm

rpmlint:
$ rpmlint ignition-math.spec ../RPMS/x86_64/ignition-math-* ../RPMS/noarch/ignition-math*
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 2 warnings

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10980494

rmattes's scratch build of ignition-math-2.2.3-1.fc22.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11525500

Updated to the latest upstream release (2.2.3)

Spec URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math.spec
SRPM URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math-2.2.3-1.fc22.src.rpm

rpmlint:
$ rpmlint ./ignition-math.spec ../RPMS/x86_64/ignition-math-* ../RPMS/noarch/ignition-math-doc-2.2.3-1.fc22.noarch.rpm 
ignition-math.x86_64: W: invalid-url URL: http://ignitionrobotics.org/libraries/math <urlopen error timed out>
ignition-math-debuginfo.x86_64: W: invalid-url URL: http://ignitionrobotics.org/libraries/math <urlopen error timed out>
ignition-math-devel.x86_64: W: invalid-url URL: http://ignitionrobotics.org/libraries/math <urlopen error timed out>
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
ignition-math-doc.noarch: W: invalid-url URL: http://ignitionrobotics.org/libraries/math <urlopen error timed out>
4 packages and 1 specfiles checked; 0 errors, 6 warnings.

I think the website being down is a temporary issue.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11525500

Eveerything looks good.

Built and submitted, closing