Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[X]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 18 files have unknown license. Detailed output of
     licensecheck in /tmp/1228230-python-oauth2client/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
     names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 6 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
     process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[X]: Uses parallel make %{?_smp_mflags} macro.
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[X]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-oauth2client , python-oauth2client-doc
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
     architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-oauth2client-1.4.11-1.fc23.noarch.rpm
          python3-oauth2client-1.4.11-1.fc23.noarch.rpm
          python-oauth2client-doc-1.4.11-1.fc23.noarch.rpm
          python-oauth2client-1.4.11-1.fc23.src.rpm
python-oauth2client.noarch: E: explicit-lib-dependency python-httplib2
python3-oauth2client.noarch: E: explicit-lib-dependency python3-httplib2
python-oauth2client-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-oauth2client/html/_static/jquery.js
4 packages and 0 specfiles checked; 2 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python-oauth2client.noarch: E: explicit-lib-dependency python-httplib2
python-oauth2client-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-oauth2client/html/_static/jquery.js
python3-oauth2client.noarch: E: explicit-lib-dependency python3-httplib2
3 packages and 0 specfiles checked; 2 errors, 1 warnings.



Requires
--------
python-oauth2client (rpmlib, GLIBC filtered):
    pyOpenSSL
    python(abi)
    python-gflags
    python-httplib2
    python-keyring
    python-pyasn1
    python-pyasn1-modules
    python-rsa
    python-six

python-oauth2client-doc (rpmlib, GLIBC filtered):

python3-oauth2client (rpmlib, GLIBC filtered):
    python(abi)
    python3-gflags
    python3-httplib2
    python3-keyring
    python3-pyOpenSSL
    python3-pyasn1
    python3-pyasn1-modules
    python3-rsa
    python3-six



Provides
--------
python-oauth2client:
    python-oauth2client

python-oauth2client-doc:
    python-oauth2client-doc

python3-oauth2client:
    python3-oauth2client



Source checksums
----------------
https://github.com/google/oauth2client/archive/v1.4.11.tar.gz#/oauth2client-1.4.11.tar.gz :
  CHECKSUM(SHA256) this package     : c7f4af0ae4ef7717fc596709e5c5d6ee5775f1fa2b2d69ccfaf0c7c42f2e6756
  CHECKSUM(SHA256) upstream package : c7f4af0ae4ef7717fc596709e5c5d6ee5775f1fa2b2d69ccfaf0c7c42f2e6756


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1228230 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

- The errors of rpmlint are false positive
- Please remove the fonts from the doc package
- Please use python versionned macros (%{python2_sitelib} and %{__python2}): https://fedoraproject.org/wiki/Packaging:Python#Macros
- gflags is not a dependency since 1.2. It must be removed from Requires. See: https://github.com/google/oauth2client/blob/c815c2babd6ed811ba426e014f03978d48f59d9c/CHANGELOG.md

- You may fetch the tarball from pypi: https://pypi.python.org/pypi/oauth2client/
- You forgot the -O1 flag for python 3 (it is there for python 2)

(In reply to Julien Enselme from comment #1)
> - Please remove the fonts from the doc package
ACK

> - Please use python versionned macros (%{python2_sitelib} and %{__python2}):
> https://fedoraproject.org/wiki/Packaging:Python#Macros
ACK

> - gflags is not a dependency since 1.2. It must be removed from Requires.
> See:
> https://github.com/google/oauth2client/blob/
> c815c2babd6ed811ba426e014f03978d48f59d9c/CHANGELOG.md

This is still needed for my dependent package (gcalcli) because it is still
using the (deprecated) API oauth2client.tools.run()

> - You may fetch the tarball from pypi:
> https://pypi.python.org/pypi/oauth2client/

I kind of prefer github as most of my packages live there, but
I can change it if you deem it necessary

> - You forgot the -O1 flag for python 3 (it is there for python 2)
ACK

Julien, thanks again for all the feedback.

Here are the new packages:
Spec URL: http://acksyn.org/files/rpms/python-oauth2client/python-oauth2client.spec
SRPM URL: http://acksyn.org/files/rpms/python-oauth2client/python-oauth2client-1.4.11-2.fc22.src.rpm

> I kind of prefer github as most of my packages live there, but
> I can change it if you deem it necessary

It is not, you can keep it this way.

> This is still needed for my dependent package (gcalcli) because it is still
> using the (deprecated) API oauth2client.tools.run()

OK.

Looks good. Approved!

New Package SCM Request
=======================
Package Name: python-oauth2client
Short Description: Python client library for OAuth 2.0
Upstream URL: https://github.com/google/oauth2client
Owners: mbaldessari
Branches: f22 epel7
InitialCC:

Git done (by process-git-requests).

I have built the package in RAWHIDE, once I have all the deps and fixes in
place for gcalcli I will try to push this on F22.

I notice that you have not specified version requirements for the dependencies of the package, even though the setup.py includes them:

install_requires = [
    'httplib2>=0.9.1',
    'pyasn1>=0.1.7',
    'pyasn1-modules>=0.0.5',
    'rsa>=3.1.4',
    'six>=1.6.1',
]

In particular, the rsa 3.1.4 requirement is not currently met in Rawhide. The result of this is that if anyone tries to use python-oauth2client as their own dependency, setuptools will try to download a more recent version from pypi.

Is there some reason you're not reflecting the setup.py dependencies in the package dependencies?

I've updated (as a provenpackager) python-rsa in Rawhide to 3.1.4 (#1226667) but the older branches still have 3.1.1.

Hi Paul,

thanks for the heads up. Brainfart on my part. I have now fixed this in rawhide.
Since python-oauth2client only exists in f23, an update of python-rsa would be needed only there (and then I can update oauth2client there as well). Can you make the magic happen there too, or do we need to wait for the maintainer via 1226667?

thanks,
Michele