Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1256341 (kf5-akonadi-calendar) - Review Request: kf5-akonadi-calendar - The Akonadi Calendar client library
Summary: Review Request: kf5-akonadi-calendar - The Akonadi Calendar client library
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-akonadi-calendar
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2015-08-24 11:50 UTC by Daniel Vrátil
Modified: 2015-12-04 14:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-04 14:46:51 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-24 11:50:58 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-calendar.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-calendar-15.08.0-1.fc22.src.rpm
Description: Akonadi Calendar client library.
Fedora Account System Username:

Comment 1 Jan Grulich 2015-09-01 09:24:44 UTC
1) License should be LGPLv2+
2) File COPYING doesn't exist, only COPYING.LIB (thus the package doesn't build)
3) These files also don't exist:
   %{_kf5_includedir}/akonadicalendar_version.h
   %{_kf5_includedir}/AkonadiCalendar 

   Use these instead:
   %{_kf5_includedir}/akonadi-calendar_version.h
   %{_kf5_includedir}/Akonadi/Calendar
   %{_kf5_includedir}/akonadi/calendar

Comment 2 Daniel Vrátil 2015-09-01 11:39:31 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-calendar.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-calendar-15.08.0-2.fc22.src.rpm

* Tue Sep 01 2015 Daniel Vrátil <dvratil> - 15.08.0-2
- fix license
- fix %%license
- fix installation

Comment 3 Jan Grulich 2015-09-01 11:55:31 UTC
Perfect, looks good now, package approved.

Comment 4 Daniel Vrátil 2015-09-01 14:55:06 UTC
New Package SCM Request
=======================
Package Name: kf5-akonadi-calendar
Short Description: The Akonadi Calendar client library
Upstream URL: https://projects.kde.org/projects/kde/pim/akonadi-calendar
Owners: dvratil group::kde-sig
Branches: f22 f23
InitialCC:

Comment 5 Gwyn Ciesla 2015-09-01 19:20:43 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.