Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1256351 (kf5-akonadi-server) - Review Request: kf5-akonadi-server - PIM Storage Service
Summary: Review Request: kf5-akonadi-server - PIM Storage Service
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-akonadi-server
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2015-08-24 12:05 UTC by Daniel Vrátil
Modified: 2015-12-04 14:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-04 14:44:11 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-24 12:05:58 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-1.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-1.fc22.src.rpm
Description: PIM Storage Service
Fedora Account System Username: dvratil
Comment 1 Daniel Vrátil 2015-08-31 14:21:41 UTC 
Correct Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server.spec
Comment 2 Jan Grulich 2015-08-31 20:57:04 UTC 
1) Some files seems to be also under GPLv2+
2) Use either only %{buildroot} or only $RPM_BUILD_ROOT
3) Invalid URL
4) Shouldn't you use %config for /etc/xdg/akonadi.categories?
5) /etc/xdg/akonadi/mysql-local.conf doesn't seem to exist, is it intentional that you create one in %install section?
Comment 3 Daniel Vrátil 2015-09-01 11:26:37 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-server-15.08.0-2.fc22.src.rpm

* Tue Sep 01 2015 Daniel Vrátil <dvratil> - 15.08.0-2
- fix license (temporarily)
- use %%{buildroot} everywhere
- fix URL
- use %%config for akonadi.categories


The GPLv2+ license is a defect known to upstream and it has been fixed recently (the files have been relicensed to LGPLv2+).

The mysql-local.conf file can act as an override for options in mysql-global.conf.
Comment 4 Jan Grulich 2015-09-01 11:41:18 UTC 
Looks good now, approved.
Comment 5 Daniel Vrátil 2015-09-01 14:54:25 UTC 
New Package SCM Request
=======================
Package Name: kf5-akonadi-server
Short Description: PIM Storage Service
Upstream URL: https://projects.kde.org/projects/kde/pim/akonadi
Owners: dvratil group::kde-sig
Branches: f22 f23
InitialCC:
Comment 6 Gwyn Ciesla 2015-09-01 19:22:54 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.