Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1257695 (signon-glib) - Review Request: signon-glib - Single signon authentication library for GLib applications
Summary: Review Request: signon-glib - Single signon authentication library for GLib a...
Keywords:
Status: CLOSED RAWHIDE
Alias: signon-glib
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews telepathy-accounts-signon
TreeView+ depends on / blocked
 
Reported: 2015-08-27 17:08 UTC by Daniel Vrátil
Modified: 2015-11-02 01:39 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-10-14 13:15:36 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+

Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-27 17:08:03 UTC 
Spec URL: https://dvratil.fedorapeople.org/applications/review/signon-glib.spec
SRPM URL: https://dvratil.fedorapeople.org/applications/review/signon-glib-1.9-1.fc22.src.rpm
Description: Single signon authentication library for GLib applications
Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2015-08-31 10:28:33 UTC 
Doesn't build, see:
./autogen.sh: line 13: gtkdocize: command not found

I guess you are missing BuildRequires: gtk-doc.

And doesn't build even later with added BR: gtk-doc because of:
libsignon-glib/Makefile.am:1: error: Libtool library used but 'LIBTOOL' is undefined
libsignon-glib/Makefile.am:1:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
libsignon-glib/Makefile.am:1:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
libsignon-glib/Makefile.am:1:   If 'LT_INIT' is in 'configure.ac', make sure
libsignon-glib/Makefile.am:1:   its definition is in aclocal's search path.
/usr/share/automake-1.15/am/ltlibrary.am: warning: 'libsignon-glib.la': linking libtool libraries using a non-POSIX
/usr/share/automake-1.15/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
libsignon-glib/Makefile.am:1:   while processing Libtool library 'libsignon-glib.la'
libsignon-glib/Makefile.am: installing 'build-aux/depcomp'
pygobject/Makefile.am:2: installing 'build-aux/py-compile'
autoreconf: automake failed with exit status: 1
Comment 2 Jan Grulich 2015-08-31 10:33:43 UTC 
I tried to build it for rawhide using fedora-review (the output above). When I try to build it locally then it builds fine, but reveals also wrong %files section, see:

Processing files: signon-glib-devel-1.9-1.fc22.x86_64
error: File not found: /home/jgrulich/rpmbuild/BUILDROOT/signon-glib-1.9-1.fc22.x86_64/usr/lib64/girepository-1.0/Signon-1.0.typelib
error: File not found: /home/jgrulich/rpmbuild/BUILDROOT/signon-glib-1.9-1.fc22.x86_64/usr/share/gir-1.0/Signon-1.0.gir
error: File not found by glob: /home/jgrulich/rpmbuild/BUILDROOT/signon-glib-1.9-1.fc22.x86_64/usr/lib64/python2.7/site-packages/gi/overrides/Signon.*
Comment 3 Upstream Release Monitoring 2015-10-13 14:04:35 UTC 
dvratil's scratch build of signon-glib-1.9-1.fc22.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11428916
Comment 4 Upstream Release Monitoring 2015-10-13 14:10:21 UTC 
dvratil's scratch build of signon-glib-1.9-1.fc22.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11429003
Comment 5 Upstream Release Monitoring 2015-10-13 14:36:14 UTC 
dvratil's scratch build of signon-glib-1.9-1.fc22.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11429257
Comment 6 Upstream Release Monitoring 2015-10-13 14:53:17 UTC 
dvratil's scratch build of signon-glib-1.9-1.fc22.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11429409
Comment 7 Daniel Vrátil 2015-10-13 14:56:44 UTC 
Spec URL: https://dvratil.fedorapeople.org/applications/review/signon-glib.spec
SRPM URL: https://dvratil.fedorapeople.org/applications/review/signon-glib-1.9-2.fc22.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11429409

 - fixed dependencies
Comment 8 Jan Grulich 2015-10-13 15:47:22 UTC 
1) Wrong version in %changelog
2) Invalid license LGPLv2.1 → LGPLv2+

Only minor issues which can be fixed during import, approved.
Comment 9 Rex Dieter 2015-10-14 10:53:20 UTC 
SCM requested in pkgdb
Comment 10 Daniel Vrátil 2015-10-14 13:15:36 UTC 
Package imported.
Note You need to log in before you can comment on or make changes to this bug.