Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1264164 - Review Request: python-rdoupdate - Manipulation and validation of YAML update files
Summary: Review Request: python-rdoupdate - Manipulation and validation of YAML update...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1246199
TreeView+ depends on / blocked
Reported: 2015-09-17 17:00 UTC by Jakub Ruzicka
Modified: 2016-08-12 15:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-08-12 15:21:07 UTC
Type: ---

Attachments (Terms of Use)

Description Jakub Ruzicka 2015-09-17 17:00:11 UTC
Spec URL:
Description: rdoupdate is a simple utility module useful for updating software repositories using YAML update files optionally stored in a git repo.
Fedora Account System Username: jruzicka

Comment 1 William Moreno 2015-10-27 16:50:52 UTC
%%prep %%build and %%install run ok with the spec but the mock build fails in the %%files section due to:

cp: cannot stat 'LICENSE': No such file or directory

The Manifest file do not include the license file:

Request upstream to include the License text in the pypi tarball, or patch the license text in %%prep.

Upstream provides some test

So you must run the test in %%chech after build  the package.

You can use these new macros to build python libs:



%{__python2} test

Also you need to create a python2-%{name} subpackage and include a python provides macro:

%package -n python2-%{name}
Requires:       xxxxx
Recommends:     xxxxx
Summary:        xxxxxx
%{?python_provide:%python_provide python2-%{name}}

Be sure to remove bundled in prep:
%setup -q
rm -rf %{name}

Comment 2 William Moreno 2015-10-27 16:53:07 UTC
Please check the current python spec template:

Comment 3 Upstream Release Monitoring 2015-10-28 23:02:41 UTC
williamjmorenor's scratch build of python-rdoupdate-0.14-2.fc22.src.rpm for rawhide failed

Comment 4 Haïkel Guémar 2015-11-06 05:25:28 UTC
* running tests is not possible as they require network access, so it's not a "must"

* fixing is indeed required

* drop the Group tag, it's unused.

* I suggest a small change in description tag
Manipulation and validation of RDO YAML update files

* Using new macros is recommended but not mandatory

For the record, Jakub is the upstream maintainer of rdoupdate.

About new python guidelines, I admit they are more consistent but renaming packages to python2-xxx is creating unnecessary issues. I would have preferred that we let the python prefix die with python2 support and keep versioned pythonX
for later major releases of Python. 
As this is not a general purpose module, it's only a dependency of rdopkg and used by a very limited set of people, I don't think it's worth enforcing this.

Comment 5 William Moreno 2015-11-26 23:29:20 UTC
Did make any progress in this packaging? Provide a python2-name, python3-name and using the python-provides macros is mandatory in Fedora Python Packaging

Comment 6 Haïkel Guémar 2016-07-15 23:02:45 UTC
I think we should close this ticket as rdoupdate is deprecated.

Comment 7 Jakub Ruzicka 2016-08-12 15:21:07 UTC
rdoupdate is now deprecated.

Note You need to log in before you can comment on or make changes to this bug.