I'm a bit confused..
How is this going to be updated ?

Does yum/dnf will pull new php-aws-sdk version 3  (especially if some package requires v3)

Or does yum/dnf wil replace it with php-aws-sdk2 (especially if some package will requires v2)

I need to think more... (Perhaps a stupid idea is to use another top dir, to allow both installation, as consumer will use the provided autoload, perhaps better to create a php-aws-sdk3, really don't know)

> Many packages 
Which ?
It seems only owncloud use it (for now)

Sorry, "package" was the wrong term to use here.  Many projects I have seen upstream have not updated to AWS API v3 or Guzzle v6 yet so I would like to keep both of these package versions available while still being able to update the main RPM packages to their latest version.

What about php-aws-sdk3 ? (like done for Guzzle)

Changed to version 3.



Spec URL: https://raw.githubusercontent.com/siwinski/rpms/bd32eb9393d157996c11eff1c3fa9e63203d3445/php-aws-sdk3/php-aws-sdk3.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-aws-sdk3-3.17.6-1.fc23.src.rpm

you may want to switch autoloader without @include_once.

I have build failure during fedora-review.

It seems "phpunit -d memory_limit=1G ..." works, can you please check ?

Hmm... scratch build ok
http://koji.fedoraproject.org/koji/taskinfo?taskID=13679876

Created attachment 1147844 [details]
phpci.log

phpCompatInfo version 5.0.0 DB version 1.7.0 built Apr 12 2016 08:25:26 CEST

Created attachment 1147845 [details]
phpci.log

phpCompatInfo version 5.0.0 DB version 1.7.0 built Apr 12 2016 08:25:26 CEST

Created attachment 1147846 [details]
review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -r -n /dev/shm/extras/SRPMS/php-aws-sdk3-3.17.6-1.fc21.remi.src.rpm
Buildroot used: fedora-rawhide-x86_64

[~]: %check is present and all tests pass.
	OK with PHP 5.6.20
	OK with PHP 7.0.6RC1
	=> some failure during fedora-review
	   mays need to increase memory-limit (1G seems enough)

[~]: Requires correct, justified where necessary.
	May want to drop Conflicts

	php-doctrine-cache < 1.4.1 don't have the autoloader so no issue
	php-doctrine-cache >= 2 when exists will probably be php-doctrine-cache2
	php-aws-php-sns-message-validator < 1 doesn't exists
	php-aws-php-sns-message-validator >= 2 will probably be php-aws-php-sns-message-validator2
	See PHP-SIG discussion.

I have to run fedora-review against an altered spec file

-%{_bindir}/phpunit --verbose --bootstrap bootstrap.php
+%{_bindir}/phpunit -d memory_limit=1G --verbose --bootstrap bootstrap.php

But, as scratch build succeeds I won't consider this as a blocker.

Some comments but no blocker, as the package complies to the Packaging Guidelines:

=== APPROVED ===

THANKS for the review!  SCM requests opened via pkgdb.



(In reply to Remi Collet from comment #10)
> you may want to switch autoloader without @include_once.

I will make this fix after initial import.



(In reply to Remi Collet from comment #10)
> [~]: %check is present and all tests pass.
> 	OK with PHP 5.6.20
> 	OK with PHP 7.0.6RC1
> 	=> some failure during fedora-review
> 	   mays need to increase memory-limit (1G seems enough)

I will modify the memory limit in the tests after initial import



> [~]: Requires correct, justified where necessary.
> 	May want to drop Conflicts
> 
> 	php-doctrine-cache < 1.4.1 don't have the autoloader so no issue
> 	php-doctrine-cache >= 2 when exists will probably be php-doctrine-cache2
> 	php-aws-php-sns-message-validator < 1 doesn't exists
> 	php-aws-php-sns-message-validator >= 2 will probably be
> php-aws-php-sns-message-validator2
> 	See PHP-SIG discussion.

We'll discuss in PHP-SIG mailing group.



> I have to run fedora-review against an altered spec file
> 
> -%{_bindir}/phpunit --verbose --bootstrap bootstrap.php
> +%{_bindir}/phpunit -d memory_limit=1G --verbose --bootstrap bootstrap.php
> 
> But, as scratch build succeeds I won't consider this as a blocker.
> 
> Some comments but no blocker, as the package complies to the Packaging
> Guidelines:
> 
> === APPROVED ===

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-aws-sdk3

php-aws-sdk3-3.18.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0973a7185f

php-aws-sdk3-3.18.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd1cc9a342

php-aws-sdk3-3.18.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0973a7185f

php-aws-sdk3-3.18.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd1cc9a342

php-aws-sdk3-3.18.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

php-aws-sdk3-3.18.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.