Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1268287 - user space tool shouldn'd end on traceback
Summary: user space tool shouldn'd end on traceback
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: tuna
Version: 7.3
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: 7.3
Assignee: John Kacur
QA Contact: Jiri Kastner
URL:
Whiteboard:
Depends On:
Blocks: 1274397 RT7.3-RHELpkgs 1313485
TreeView+ depends on / blocked
 
Reported: 2015-10-02 12:38 UTC by Tereza Cerna
Modified: 2016-11-04 05:15 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Tuna will now display a usage message if the user doesn't supply a value to the -c option.
Clone Of:
Environment:
Last Closed: 2016-11-04 05:15:12 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Display usage msg instead of traceback when arg to -c is missing or nonesense (deleted)
2016-05-30 19:11 UTC, John Kacur
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:2392 0 normal SHIPPED_LIVE tuna bug fix and enhancement update 2016-11-03 13:54:24 UTC

Description Tereza Cerna 2015-10-02 12:38:13 UTC
User space tool shouldn't end on traceback.

# rpm -q tuna tuned
tuna-0.11.1-10.el7.noarch
tuned-2.5.1-4.el7.noarch

# tuna -c -P
Traceback (most recent call last):
  File "/usr/bin/tuna", line 656, in <module>
    main()
  File "/usr/bin/tuna", line 494, in main
    op_list = tuna.cpustring_to_list(a)
  File "/usr/lib/python2.7/site-packages/tuna/tuna.py", line 124, in cpustring_to_list
    ends = [ int(a, 0) for a in field.split("-") ]
ValueError: invalid literal for int() with base 0: 'P'

Second founded traceback:

# tuned-adm profile realtime
# tuned-adm verify
Verification failed, current system settings differ from the preset profile.
See tuned.log for details. You can mostly fix this by Tuned restart, e.g.:
  service tuned restart
# cat /var/log/tuned/tuned.log 
...
2015-10-02 13:15:50,510 INFO     tuned.plugins.plugin_script: calling script '/usr/lib/tuned/realtime/script.sh' with argument 'verify'
2015-10-02 13:15:50,618 ERROR    tuned.plugins.plugin_script: script '/usr/lib/tuned/realtime/script.sh' error: 1, 'Traceback (most recent call last):
  File "/usr/bin/tuna", line 656, in <module>
    main()
  File "/usr/bin/tuna", line 493, in main
    (op, a) = pick_op(a)
  File "/usr/bin/tuna", line 408, in pick_op
    if argument[0] in ('+', '-'):
IndexError: string index out of range'
2015-10-02 13:15:50,619 ERROR    tuned.plugins.plugin_script: verify: failed: [u'/usr/lib/tuned/realtime/script.sh']
...

Comment 1 Jaroslav Škarvada 2015-10-02 12:39:52 UTC
$ tuna -c "" -P
Traceback (most recent call last):
  File "/usr/bin/tuna", line 647, in <module>
    main()
  File "/usr/bin/tuna", line 490, in main
    (op, a) = pick_op(a)
  File "/usr/bin/tuna", line 405, in pick_op
    if argument[0] in ('+', '-'):
IndexError: string index out of range

Tuna should verify the input and not traceback.

Comment 3 John Kacur 2016-05-30 19:11:10 UTC
Created attachment 1162956 [details]
Display usage msg instead of traceback when arg to -c is missing or nonesense

I sent this patch upstream

Comment 4 John Kacur 2016-05-30 19:12:27 UTC
Fixed in tuna-0.13-3.el7 and up

Comment 8 errata-xmlrpc 2016-11-04 05:15:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2392.html


Note You need to log in before you can comment on or make changes to this bug.