Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1272974 - Fix regression detecting s390 CTC devices
Summary: Fix regression detecting s390 CTC devices
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Rashid Khan
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-10-19 10:24 UTC by Thomas Haller
Modified: 2015-11-19 11:06 UTC (History)
8 users (show)

Fixed In Version: NetworkManager-1.0.6-22.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 11:06:32 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2315 0 normal SHIPPED_LIVE Moderate: NetworkManager security, bug fix, and enhancement update 2015-11-19 10:06:58 UTC

Description Thomas Haller 2015-10-19 10:24:12 UTC 
Originally and on RHEL-7.1, we detected s390 CTC devices like:

        if (arptype == 256) {
            /* Some s390 CTC-type devices report 256 for the encapsulation type
             * for some reason, but we need to call them Ethernet. FIXME: use
             * something other than interface name to detect CTC here.
             */
            if (g_str_has_prefix (ifname, "ctc"))
                return_type (NM_LINK_TYPE_ETHERNET, "ethernet");
        }



Bug 1212118 and upstream commit [1] implemented better device detection for s390 CTC devices.


This was later broken entirely due to commit [2].



[1] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=02c6a9334335d3ef32c6cc8fafc6cea235c80ffc

[2] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ddaea22332907c05222cbec1e1b4365689fbda9f
Comment 1 Thomas Haller 2015-10-19 10:28:17 UTC 
This is fixed upstream:

master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8a6afe92c18dfefa91d057518be00b0127720fa5

nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2a8c93e940c3fdc5bb710f9fd1ec037e51524ed9





RHEL-7.1 would detect CTC devices based on the interface name.

RHEL-7.2 would not detect them properly at all.
This is a regression.


Propose backporting the trivial fix.
Comment 4 errata-xmlrpc 2015-11-19 11:06:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2315.html
Note You need to log in before you can comment on or make changes to this bug.