Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1282097 - python-mpd: [PATCH] port to python3
Summary: python-mpd: [PATCH] port to python3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-mpd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tomas Orsava
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-PUSH
TreeView+ depends on / blocked
 
Reported: 2015-11-14 22:00 UTC by Ralph Bean
Modified: 2016-05-25 16:20 UTC (History)
5 users (show)

Fixed In Version: python-mpd-0.2.1-12.fc25
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-25 16:20:33 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Port to python3 and modernize python macros. (4.22 KB, patch)
2015-11-14 22:00 UTC, Ralph Bean 		no flags Details | Diff
Python 3 support patch (4.25 KB, patch)
2016-05-19 09:29 UTC, Tomas Orsava 		no flags Details | Diff
View All

Description Ralph Bean 2015-11-14 22:00:36 UTC 
Created attachment 1094218 [details]
Port to python3 and modernize python macros.

Upstream appears to be dead :(  but here's a patch!
Comment 1 Jan Kurik 2016-02-24 13:57:32 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Comment 2 Toshio Ernie Kuratomi 2016-02-28 12:30:29 UTC 
Still not built for python3 in rawhide.
Comment 3 Ralph Bean 2016-03-29 01:37:40 UTC 
Haïkel, any chance to apply this?
Comment 4 Tomas Orsava 2016-05-19 09:29:47 UTC 
Created attachment 1159332 [details]
Python 3 support patch

Hi, Ralph!

Thank you for submitting a patch for Python 3!
As the maintainer has not responded in a long time, I hope that they won't mind if we review and push the patch ourselves.

I made a few changes during the review:
- Rebased the patch onto current version of spec file as it did not apply cleanly.
- Summary and descriptions of subpackages were referring to a different package, fixed that.
- Added doc/commands.txt file into %doc

Overall the patch looks great, thank you very much!

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14166105
Comment 5 Miro Hrončok 2016-05-19 11:47:05 UTC 
Applied, pushed, building http://koji.fedoraproject.org/koji/taskinfo?taskID=14168321
Note You need to log in before you can comment on or make changes to this bug.