Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1288651 (OpenIGTLink) - Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol
Summary: Review Request: openigtlink - Implementation of the OpenIGTLink network commu...
Keywords:
Status: CLOSED RAWHIDE
Alias: OpenIGTLink
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: fedora-neuro
TreeView+ depends on / blocked
 
Reported: 2015-12-04 21:23 UTC by Dmitry Mikhirev
Modified: 2016-02-02 21:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-02 21:10:57 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Dmitry Mikhirev 2015-12-04 21:23:17 UTC 
Spec URL:
SRPM URL:

Description:

The OpenIGTLink Library is a reference implementation of OpenIGTLink protocol. It is required to build 3D-Slicer that I'm going to package.

OpenIGTLink is a network communication protocol specifically designed and developed for research on image-guided and computer-assisted interventions. It provides a standardized mechanism for communications among computers and devices in operating rooms (OR) for a wide variety of image-guided therapy (IGT) applications. Examples of such applications include:

- Stereotactic surgical guidance using optical position sensor and medical image visualization software
- Intraoperative image guidance using real-time MRI and medical image visualization software
- Robot-assisted interventions using robotic devices and surgical planning software

OpenIGTLink is a set of messaging formats and rules (protocol) used for data exchange on a local area network (LAN).
Comment 1 Dmitry Mikhirev 2015-12-04 21:26:04 UTC 
I'm sorry, forgot to paste URLs:

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/OpenIGTLink.git/plain/OpenIGTLink.spec?id=dcd4b2f058890e46f74a31d47661e4ddeecb97b3
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00143768-OpenIGTLink/OpenIGTLink-0-0.1.20151015gitccb2438.fc24.src.rpm
Comment 2 Zbigniew Jędrzejewski-Szmek 2016-01-08 19:45:53 UTC 
The name should be lowercase [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming], it's hard to remember (or type) or those mixed-case letters.

You could use a single doc directory:
%global _docdir_fmt %{name}

Don't repeat the package name in summary. It's also better to drop the article, listings look better without.

I don't see any issues otherwise.
Comment 3 Dmitry Mikhirev 2016-01-23 20:08:53 UTC 
> The name should be lowercase
I hate mixed-case letters too, but the upstream always refers to this library as OpenIGTLink, like in ORBit example on the wiki page. The github repository (and source tarball archived from there) is also named in mixed-case.

> Don't repeat the package name in summary.
It is not a package name, it's a protocol name. Shouldn't the package summary for protocol implementation include the protocol name? Really, I don't know what to write there if not this...
Comment 4 Zbigniew Jędrzejewski-Szmek 2016-01-23 20:39:40 UTC 
(In reply to Dmitry Mikhirev from comment #3)
> > The name should be lowercase
> I hate mixed-case letters too, but the upstream always refers to this
> library as OpenIGTLink, like in ORBit example on the wiki page. The github
> repository (and source tarball archived from there) is also named in
> mixed-case.
That's fine. You should use capitalized name in the description and other docs. Just the package name should be lowercase.

> > Don't repeat the package name in summary.
> It is not a package name, it's a protocol name. Shouldn't the package
> summary for protocol implementation include the protocol name? Really, I
> don't know what to write there if not this...

OK, if the package name will be lowercase, it might make more sense to repeat the protocol name. Maybe Summary: implementation of the OpenIGTLink network protocol ?
Comment 5 Dmitry Mikhirev 2016-01-23 21:32:16 UTC 
Thank you! I fixed evrything as you adviced.

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openigtlink.git/plain/openigtlink.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawhide-x86_64/00155407-openigtlink/openigtlink-0-0.1.20151015gitccb2438.fc24.src.rpm
Comment 6 Zbigniew Jędrzejewski-Szmek 2016-01-23 22:47:47 UTC 
+ license is acceptable (BSD)
+ license file is present, %license is used
+ name is correct
+ scriptlets are OK
+ builds and installs fine
+ provides and requires look fine
+ recent version (git)
+ %check is present

Package is APPROVED.
Comment 7 Gwyn Ciesla 2016-01-24 19:02:05 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/openigtlink
Note You need to log in before you can comment on or make changes to this bug.