Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1301253 - Review Request: color - A string colorizer
Summary: Review Request: color - A string colorizer
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/awd123/color
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2016-01-23 02:41 UTC by Austin Dunn
Modified: 2020-07-16 03:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
awd123ps: needinfo-

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1268697 0 unspecified CLOSED Review Request: color - colorize text 2022-05-16 11:32:56 UTC
Red Hat Bugzilla 1300465 0 unspecified CLOSED Review Request: color - A string colorizer. 2022-05-16 11:32:56 UTC

Internal Links: 1268697 1300465

Description Austin Dunn 2016-01-23 02:41:28 UTC 
Spec URL: http://terrydunn.org/color/color.spec
SRPM URL: http://terrydunn.org/color/color-0.2.1-1.fc23.src.rpm
Description: This program uses ANSI escape codes to colorize a string passed to it either by argv or stdin.
Fedora Account System Username: awd123
Comment 1 Brandon Thomas 2016-01-24 22:25:06 UTC 
This is not an official review, and this does not effect the status of the review request.
* It looks like a period slipped into the packages Summary.
* I don't believe that Amusements/Games" is a valid group.
* "make %{?_smp_mflags}" can be replaced with "%make_build".
* You don't need to specify the packager.
* You probably want the install and ln command to be in the "%install" section.
* You might want to consider including a change log at the end of your file.
Comment 2 Austin Dunn 2016-01-25 00:06:04 UTC 
(In reply to Brandon Thomas from comment #1)

Thanks for the review!

> * I don't believe that Amusements/Games" is a valid group.
Amusements/Games is a valid group. Try "cat /usr/share/doc/rpm/GROUPS"

> * "make %{?_smp_mflags}" can be replaced with "%make_build".
That was in the vim .spec template, I will fix it in an update.

> * You probably want the install and ln command to be in the "%install"
See above.
Comment 3 Petr Pisar 2016-01-29 13:30:27 UTC 
You seems to not be in packager group yet, so I added the required "blocks" dependency to this bug report. I hope some packager sponsor reach you. To the package:

The License value is not valid one. See <https://fedoraproject.org/wiki/Licensing> for the list of available identifiers.

The program requires C compiler to build. You should build-requires gcc. See <https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B>.

The spec file invokes make command, so it should build-require it.

The LICENSE file must be packaged using %license macro. See <https://fedoraproject.org/wiki/Packaging:LicensingGuidelines>.
Comment 4 Package Review 2020-07-10 00:54:22 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.
Note You need to log in before you can comment on or make changes to this bug.