Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1307200 (kjots) - Review Request: kjots - KDE Notes application
Summary: Review Request: kjots - KDE Notes application
Keywords:
Status: CLOSED ERRATA
Alias: kjots
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2016-02-13 00:35 UTC by Daniel Vrátil
Modified: 2016-05-10 11:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-10 11:47:10 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1314974 0 medium CLOSED Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications 2022-05-16 11:32:56 UTC

Internal Links: 1314974

Description Daniel Vrátil 2016-02-13 00:35:11 UTC 
Spec URL: https://dvratil.fedorapeople.org/spec/kjots.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/kjots-5.0.1-1.fc23.src.rpm
Description: KJots is an application for writing and organizing notes. KJots used to be part of the kdepim package, but as of 15.08 it was removed from KDE PIM. KJots is now being released as a standalone application outside of KDE Applications.
Fedora Account System Username: dvratil
Comment 1 Rex Dieter 2016-03-03 18:59:32 UTC 
Offhand, for upgrade path, probably need to introduce at least:
Epoch: 7
since that's what previous kdepim package used
Comment 2 Rex Dieter 2016-03-03 19:17:12 UTC 
Nevermind, I see we foresaw that and included
Epoch: 0
in the subpkgs before.
Comment 3 Rex Dieter 2016-03-11 12:55:17 UTC 
naming: ok

sources: ok
edb0a82781dbb75d1fe69f2eb6f7cf28  kjots-5.0.1.tar.xz

license: ok

scriptlets: NOT ok

1.  icon scriptlets reference (undefined?) macro: %{_iconsdir}, probably want instead: %{_datadir}/icons  (or define %_iconsdir)

2.  MUST add appdata validation scriptlet
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage

3. SHOULD use better URL, something like
URL:  http://projects.kde.org/kjots

4.  MUST include licenses in %files, add:
%license COPYING
and optinally
%license COPYING.LIB 
too
Comment 4 Rex Dieter 2016-03-15 20:37:19 UTC 
ping, can you give an update?
Comment 5 Daniel Vrátil 2016-03-20 21:21:32 UTC 
Spec URL: https://dvratil.fedorapeople.org/spec/kjots.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/kjots-5.0.1-2.fc23.src.rpm

* Mon Mar 14 2016 Daniel Vrátil <dvratil> - 5.0.1-2
- fix url
- fix scriptlets
- fix %%license and %%doc
- validate appdata
Comment 6 Rex Dieter 2016-03-20 21:48:10 UTC 
looks good, approved
Comment 7 Gwyn Ciesla 2016-03-21 14:34:41 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kjots
Comment 8 Rex Dieter 2016-03-29 13:58:45 UTC 
I see kjots imported and built, closing
Comment 9 Raphael Groner 2016-03-29 14:15:26 UTC 
https://bodhi.fedoraproject.org/updates/kjots → 404

Can you provide an (at least test) build for Fedora 23?
Comment 10 Daniel Vrátil 2016-03-30 23:39:00 UTC 
Raphael, this kjots package is only available in F24 and rawhide. On F23 we ship KDEPIM4, where KJots is available as part of the kdepim package.
Comment 11 Raphael Groner 2016-03-31 07:17:33 UTC 
You talk about bug #1314974, right?
Comment 12 Daniel Vrátil 2016-03-31 09:24:23 UTC 
No. In Fedora <= 23 we ship kdepim 4.14.x in package "kdepim" based on Qt4 and KDE4 (called usually "KDEPIM4"), which includes KJots and all the other KDE PIM applications. In F24 we updated to kdepim 15.12 as part of KDE Applications 15.12 release which is based on Qt5 and KF5  (called "KDEPIM5") and is not compatible with the KDE4 versions. KJots has been ported to Qt5 too, but is being released separately by upstream, not as part of KDE Applications. Therefore it's not part of the "kdepim4" compatibility package from bug #1314974, but a standalone package.
Comment 13 Fedora Update System 2016-05-05 12:27:43 UTC 
kjots-5.0.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8
Comment 14 Fedora Update System 2016-05-06 11:27:54 UTC 
kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-53e405b0c8
Comment 15 Fedora Update System 2016-05-10 11:47:06 UTC 
kjots-5.0.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.