Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1307345 - bfast: FTBFS in rawhide
Summary: bfast: FTBFS in rawhide
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: bfast
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Huffman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F24FTBFS
TreeView+ depends on / blocked
 
Reported: 2016-02-13 21:04 UTC by Fedora Release Engineering
Modified: 2016-03-23 11:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-23 11:44:40 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
build.log (62.11 KB, text/plain)
2016-02-13 21:04 UTC, Fedora Release Engineering 		no flags Details
root.log (84.79 KB, text/plain)
2016-02-13 21:04 UTC, Fedora Release Engineering 		no flags Details
state.log (621 bytes, text/plain)
2016-02-13 21:04 UTC, Fedora Release Engineering 		no flags Details
Patch to fix the FTBFS (2.50 KB, patch)
2016-02-19 03:42 UTC, Ralf Corsepius 		no flags Details | Diff
View All

Description Fedora Release Engineering 2016-02-13 21:04:15 UTC 
Your package bfast failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12807655

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
Comment 1 Fedora Release Engineering 2016-02-13 21:04:18 UTC 
Created attachment 1124105 [details]
build.log
Comment 2 Fedora Release Engineering 2016-02-13 21:04:19 UTC 
Created attachment 1124106 [details]
root.log
Comment 3 Fedora Release Engineering 2016-02-13 21:04:20 UTC 
Created attachment 1124107 [details]
state.log
Comment 4 Ralf Corsepius 2016-02-19 03:42:31 UTC 
Created attachment 1128409 [details]
Patch to fix the FTBFS

Trigger of this FTFBS is this package is still relying on gnu89-inlining.

As this feature change was added to GCC-5, I wonder why this wasn't caught during the gcc-5 mass-rebuilt and didn't trigger an F23FTBFS. I assume it actually triggered an F23FTBFS (f23 still ships an f22 package), but the related BZ (RHBZ#1239386) seemingly was prematurely closed.

Anyway, the patch from the attachment should fix this issue and more related issues this package has and bring it back on track.

Unless somebody objects, I will apply this patch to rawhide and f23 in near future.
Comment 5 Upstream Release Monitoring 2016-02-19 09:01:42 UTC 
verdurin's bfast-0.7.0a-14.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=736899
Comment 6 Jan Kurik 2016-02-24 14:34:36 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Comment 7 Yaakov Selkowitz 2016-02-24 21:39:32 UTC 
Shouldn't that be:

"CFLAGS=%optflags -fgnu89-inline"
%configure
Comment 8 Ralf Corsepius 2016-02-25 05:25:09 UTC 
(In reply to Yaakov Selkowitz from comment #7)
> "CFLAGS=%optflags -fgnu89-inline"
> %configure
Well, it should not matter.

In %build, modern rpm first exports CFLAGS, which is where it later is picked up by %configure:

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.e1SA4N
+ umask 022
+ cd /builddir/build/BUILD
+ cd bfast-0.7.0a
+ CFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/r
+ export CFLAGS
...
+ ./configure ...
...

But you are right, %optflags would have been an alternative.



@verdurin: Provided you applied this patch and rebuilt this package, please assign this BZ to you and close this BZ.
Comment 9 Ralf Corsepius 2016-03-23 11:44:40 UTC 
Why wasn't this BZ closed? Closing
Note You need to log in before you can comment on or make changes to this bug.