Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1308557 - python-grapefruit: Provide a Python 3 subpackage
Summary: python-grapefruit: Provide a Python 3 subpackage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-grapefruit
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Praveen Kumar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-AVAILABLE 1356653
TreeView+ depends on / blocked
 
Reported: 2016-02-15 13:51 UTC by Petr Viktorin
Modified: 2017-03-10 14:50 UTC (History)
5 users (show)

Fixed In Version: python-grapefruit-0.1a4-5.fc27 python-grapefruit-0.1a4-5.fc26 python-grapefruit-0.1a4-3.fc25 python-grapefruit-0.1a4-3.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-03 21:50:47 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Patch to fix python3-grapefruit dragging in Python 2 (1.39 KB, application/mbox)
2017-03-01 16:33 UTC, Iryna Shcherbina 		no flags Details
View All

Description Petr Viktorin 2016-02-15 13:51:32 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's fine to do this in Rawhide only.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Comment 1 Jan Kurik 2016-02-24 15:21:30 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Comment 2 Ariel O. Barria 2016-08-02 16:26:03 UTC 
Hello everyone.

Adding support for python3.

SPEC:
https://arielb.fedorapeople.org/python-grapefruit.spec
SRPM:
https://arielb.fedorapeople.org/python-grapefruit-0.1a4-1.fc24.src.rpm

koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15105162
Comment 3 Dominika Krejčí 2016-10-12 15:35:02 UTC 
Hi Ariel,
I have some comments:

* Please, add the %check section, tests are present, you can run them with `%{__pythonX} setup.py test`.

* There is a typo in URL, please delete `%` at the end.


And rpmlint output:

* `python-grapefruit.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 7)`

* `python-grapefruit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grapefruit.py 644 /usr/bin/python`

* `python3-grapefruit.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/grapefruit.py 644 /usr/bin/python`
Comment 4 Fedora Update System 2016-10-14 03:21:03 UTC 
python-grapefruit-0.1a4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cacb84cd7
Comment 5 Fedora Update System 2016-10-14 04:56:27 UTC 
python-grapefruit-0.1a4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ef645f5614
Comment 6 Fedora Update System 2017-02-24 22:49:39 UTC 
python-grapefruit-0.1a4-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2017-02-24 23:18:32 UTC 
python-grapefruit-0.1a4-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 8 Iryna Shcherbina 2017-03-01 16:33:42 UTC 
Created attachment 1258810 [details]
Patch to fix python3-grapefruit dragging in Python 2

Reopening the issue, as python3-grapefruit-0.1a4-4 RPM requires both Python 2 and Python 3. There is a stray "/usr/bin/python" shebang in one of the files, which auto-generates the dependency on Python 2.

You may find the change needed to fix auto-generating Python 2 dependency attached. Please review and apply it.

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18126431
Comment 9 Fedora Update System 2017-03-02 10:13:36 UTC 
python-grapefruit-0.1a4-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-371de561fc
Comment 10 Fedora Update System 2017-03-02 10:20:44 UTC 
python-grapefruit-0.1a4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce95a69a4b
Comment 11 Fedora Update System 2017-03-03 04:53:05 UTC 
python-grapefruit-0.1a4-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-371de561fc
Comment 12 Fedora Update System 2017-03-03 05:23:52 UTC 
python-grapefruit-0.1a4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce95a69a4b
Comment 13 Fedora Update System 2017-03-03 21:50:47 UTC 
python-grapefruit-0.1a4-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 14 Fedora Update System 2017-03-10 14:50:40 UTC 
python-grapefruit-0.1a4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.