Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1313932 - coccinelle: Provide a Python 3 subpackage
Summary: coccinelle: Provide a Python 3 subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: coccinelle
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tomas Orsava
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-PUSH
TreeView+ depends on / blocked
 
Reported: 2016-03-02 16:04 UTC by Tomas Orsava
Modified: 2016-05-11 09:59 UTC (History)
4 users (show)

Fixed In Version: coccinelle-1.0.4-6.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-11 09:59:45 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Python 3 patch for specfile (2.11 KB, patch)
2016-04-20 08:30 UTC, Dominika Krejčí 		no flags Details | Diff
Patch to port the specfile to Python 3 (2.40 KB, patch)
2016-04-26 13:42 UTC, Tomas Orsava 		no flags Details | Diff
Patch to change shebang to Python 3 (1.19 KB, patch)
2016-05-02 13:44 UTC, Tomas Orsava 		no flags Details | Diff
Show Obsolete (2) View All

Description Tomas Orsava 2016-03-02 16:04:53 UTC 
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Comment 1 Richard W.M. Jones 2016-03-03 12:38:49 UTC 
I think it'd be better for everyone if the Python team just went
in and made the changes.  Apparently building twice and setting
PYTHON=/usr/bin/python3 the second time should be sufficient.
Comment 2 Dominika Krejčí 2016-04-20 08:30:34 UTC 
Created attachment 1148891 [details]
Python 3 patch for specfile

SRPM: https://copr-be.cloud.fedoraproject.org/results/dkrejci/coccinelle/fedora-rawhide-x86_64/00175584-coccinelle/coccinelle-1.0.4-5.fc25.src.rpm

Copr link: https://copr.fedorainfracloud.org/coprs/dkrejci/coccinelle/build/175584/
Comment 3 Tomas Orsava 2016-04-26 13:42:01 UTC 
Created attachment 1150970 [details]
Patch to port the specfile to Python 3

I polished Dominika's patch a bit. Specifically I've done away with the removal of the devel-file as we aren't sure at this point if it is needed or not. Better to live with an RPMlint warning.
Comment 4 Tomas Orsava 2016-04-26 13:43:33 UTC 
Here's a Koji scratch build of the resulting SRPM: http://koji.fedoraproject.org/koji/taskinfo?taskID=13810091
Comment 5 Miro Hrončok 2016-04-28 11:42:04 UTC 
Let's roll.
Comment 6 Miro Hrončok 2016-04-28 11:47:11 UTC 
http://koji.fedoraproject.org/koji/taskinfo?taskID=13835033
Comment 7 Miro Hrončok 2016-04-28 12:01:14 UTC 
Waiting only on ARM build.

Tomáš, Dominika, please check if everything works as expected
Comment 8 Miro Hrončok 2016-04-28 12:08:18 UTC 
ARM build finished.
Comment 9 Tomas Orsava 2016-05-02 13:44:23 UTC 
Created attachment 1152968 [details]
Patch to change shebang to Python 3

I checked it in mock and found out I forgot one shebang still pointing to Python 2. I attached a patch (against the current contents of the dist-git) that fixes the issue.

I apologize for the omission.
Comment 10 Tomas Orsava 2016-05-05 09:58:46 UTC 
Here's a link to a Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=13930548
Comment 11 Miro Hrončok 2016-05-05 12:21:03 UTC 
http://koji.fedoraproject.org/koji/taskinfo?taskID=13931665
Comment 12 Richard W.M. Jones 2016-05-05 13:02:49 UTC 
Thanks for fixing/implementing this.
Comment 13 Tomas Orsava 2016-05-06 12:17:51 UTC 
We're glad to have helped, Richard!

Do you think you could test the package if it's working as expected?
Comment 14 Tomas Orsava 2016-05-11 09:59:45 UTC 
I'm not as familiar with the package, but after some testing inside mock, everything looks good! Thanks everyone!
Note You need to log in before you can comment on or make changes to this bug.