Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1317888 - python-yourls: Provide a Python 3 subpackage
Summary: python-yourls: Provide a Python 3 subpackage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-yourls
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Flink
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1348207
Blocks: PYTHON3 PY3PATCH-AVAILABLE
TreeView+ depends on / blocked
 
Reported: 2016-03-15 12:57 UTC by Tomas Orsava
Modified: 2017-12-01 03:43 UTC (History)
6 users (show)

Fixed In Version: python-yourls-0.2.0-12.fc28 python-yourls-0.2.0-12.fc27 python-yourls-0.2.0-11.fc26
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-30 15:38:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch for spec: add Python3 and new Requires, version and source update (deleted)
2016-06-15 13:10 UTC, Dominika Krejčí
no flags Details | Diff
patch for spec: add Python3 and new Requires, version and source update (deleted)
2016-08-18 13:47 UTC, Dominika Krejčí
no flags Details | Diff
Python 3 support (deleted)
2017-05-26 14:59 UTC, Charalampos Stratakis
no flags Details | Diff
Python 3 support (deleted)
2017-05-26 15:01 UTC, Charalampos Stratakis
no flags Details

Description Tomas Orsava 2016-03-15 12:57:23 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Comment 1 Dominika Krejčí 2016-05-13 11:21:54 UTC
Hello Tim,

do you need any help adding Python 3 support to the RPM?

If you need more instructions, a [guide] for porting Python-based RPMs is available.

[guide] http://python-rpm-porting.readthedocs.io/

Comment 2 Dominika Krejčí 2016-06-15 13:10:51 UTC
Created attachment 1168371 [details]
patch for spec: add Python3 and new Requires, version and source update

Hi,
there is a patch for the specfile to make it Python3 compatible.
It is not working because there is a new required package, which is not packaged yet. It is python-represent (https://pypi.python.org/pypi/Represent/), until this is not packaged, yourls cannot be ported.

Comment 3 Jan Kurik 2016-07-26 05:07:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 4 Dominika Krejčí 2016-08-18 13:47:15 UTC
Created attachment 1191874 [details]
patch for spec: add Python3 and new Requires, version and source update

python-represent is ready and there is a new patch

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15295700

Tim, could you please review it and push it? :)

Comment 5 Martin Krizek 2016-08-18 14:13:43 UTC
I am curious as to why did you change the upstream project: https://github.com/tflink/python-yourls to https://github.com/RazerM/yourls-python and if that's even allowed according to the Packaging Guidelines?

Comment 6 Dominika Krejčí 2016-08-18 14:29:34 UTC
(In reply to Martin Krizek from comment #5)
> I am curious as to why did you change the upstream project:
> https://github.com/tflink/python-yourls to
> https://github.com/RazerM/yourls-python and if that's even allowed according
> to the Packaging Guidelines?

Tflink's repo seems to be dead and the razerm'm one is mentioned at PyPI [0] as a Home Page.

[0] https://pypi.python.org/pypi/yourls

Comment 7 Martin Krizek 2016-08-19 08:31:52 UTC
python-yourls is a package of https://github.com/tflink/python-yourls which is not on PyPI and have different API than https://github.com/RazerM/yourls-python. Changing the project would mean to break API of the python-yourls package.

I understand and agree with using a project that is more active but it should be packaged as a new package, changing upstream doesn't seem correct to me.

Comment 8 Tomas Orsava 2016-08-19 08:40:03 UTC
Hi Martin!
I think you can understand how the names 'python-yourls' and 'yourls-python' can be viewed interchangeable, especially given that the 'python' part is oftentimes mandatory in the name (as it is for Fedora packages).

I believe Dominika misunderstood these projects as forks of the same codebase, so thank you for clearing the confusion.

Comment 9 Martin Krizek 2016-08-19 08:51:52 UTC
Yeah, I understand where the confusion came from. Just wondering what the correct approach would be to replace dead project with the active one.

Comment 10 Tomas Orsava 2016-08-19 08:57:36 UTC
If the APIs are different then a new package should be created I believe.

Otherwise an update of this package would suddenly break all the packages that depend on it.

Comment 11 Lumír Balhar 2016-09-12 09:48:46 UTC
Hello.

What is the final decision? Is this bug still active or do you have a new package?

Comment 12 Charalampos Stratakis 2017-05-26 14:59:38 UTC
Created attachment 1282643 [details]
Python 3 support

Here is a patch for providing a Python 3 subpackage as well as building the documentation.

Also I added some changes to conform to the latest packaging guidelines.

Could you review the patch and apply it? Already tested everything in mock, it seems to work fine.

Comment 13 Charalampos Stratakis 2017-05-26 15:01:09 UTC
Created attachment 1282644 [details]
Python 3 support

Small change for the changelog.

Comment 14 Fedora End Of Life 2017-11-16 19:09:18 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 15 Fedora Update System 2017-11-20 16:57:23 UTC
python-yourls-0.2.0-11.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8a39d2b513

Comment 16 Fedora Update System 2017-11-22 06:31:17 UTC
python-yourls-0.2.0-12.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-891b7c6ff3

Comment 17 Fedora Update System 2017-11-22 11:08:30 UTC
python-yourls-0.2.0-11.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8a39d2b513

Comment 18 Fedora Update System 2017-11-30 15:38:43 UTC
python-yourls-0.2.0-12.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2017-12-01 03:43:00 UTC
python-yourls-0.2.0-11.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.