Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1317896 - python-zope-processlifetime: Provide a Python 3 subpackage
Summary: python-zope-processlifetime: Provide a Python 3 subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-zope-processlifetime
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralph Bean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-AVAILABLE
TreeView+ depends on / blocked
 
Reported: 2016-03-15 13:03 UTC by Tomas Orsava
Modified: 2016-07-27 20:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-27 20:09:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch for python-zope-processlifetime.spec (deleted)
2016-07-20 12:17 UTC, Petri Ylitalo
no flags Details | Diff
Revised patch for python-zope-processlifetime specfile (deleted)
2016-07-21 05:57 UTC, Petri Ylitalo
no flags Details | Diff
PY3 port patch (deleted)
2016-07-23 08:21 UTC, Petri Ylitalo
no flags Details | Diff

Description Tomas Orsava 2016-03-15 13:03:20 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Comment 1 Petri Ylitalo 2016-07-20 12:17:44 UTC
Created attachment 1182100 [details]
Patch for python-zope-processlifetime.spec

Hi,

This is my first patch submitted to Bugzilla. I hope everything is in order. I built and tested it on F23, also ran a mock build. I did't find any simple way to test functionality but comparing to previous version the files appeared to be in the right places for python3. Please review the patch and push it if it's ok.

Thanks,
Petri

Comment 2 Petri Ylitalo 2016-07-21 05:57:17 UTC
Created attachment 1182319 [details]
Revised patch for python-zope-processlifetime specfile

Realised that I did not include python2 in the first patch. This one follows porting guide lines.

Comment 3 Petri Ylitalo 2016-07-23 08:21:25 UTC
Created attachment 1183061 [details]
PY3 port patch

Corrected %changelog entries

Comment 4 Jan Kurik 2016-07-26 04:58:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 5 Ralph Bean 2016-07-27 20:09:25 UTC
Looks good to me.  Thanks!

I made a few adjustments to your patch to use some of the modern python macros:

http://pkgs.fedoraproject.org/cgit/rpms/python-zope-processlifetime.git/commit/?id=e004f02c11b1b8b763220e8360e873b34924a746

Thanks again!


Note You need to log in before you can comment on or make changes to this bug.