Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1318969 - Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs
Summary: Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on con...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1231104
TreeView+ depends on / blocked
 
Reported: 2016-03-18 09:41 UTC by Petr Pisar
Modified: 2016-10-19 11:01 UTC (History)
2 users (show)

Fixed In Version: perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-19 11:01:30 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 823166 0 unspecified CLOSED Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs 2022-05-16 11:32:56 UTC

Internal Links: 823166

Description Petr Pisar 2016-03-18 09:41:11 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-B-Hooks-OP-Check-EntersubForCV/perl-B-Hooks-OP-Check-EntersubForCV.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-B-Hooks-OP-Check-EntersubForCV/perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24.src.rpm
Description:
Invoke callbacks on construction of entersub OPs for certain CVs.

Fedora Account System Username: ppisar
Comment 1 Petr Pisar 2016-03-18 09:43:37 UTC 
This unretires a package removed from Fedora because of incompatibility with Perl 5.22.
Comment 2 Jitka Plesnikova 2016-03-29 11:01:16 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(B::Hooks::OP::Check) >= 0.19
      1 perl(B::Utils) >= 0.19
      1 perl(DynaLoader)
      1 perl(Scalar::Util)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
$ rpm -qp --requires perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
      1 perl-devel(x86-64)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 perl(B::Hooks::OP::Check::EntersubForCV) = 0.09
      1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-13.fc25
      1 perl-B-Hooks-OP-Check-EntersubForCV(x86-64) = 0.09-13.fc25
$ rpm -qp --provides perl-B-Hooks-OP-Check-EntersubForCV-devel-0.09-13.fc25.x86_64.rpm | sort | uniq -c
      1 perl(B::Hooks::OP::Check::EntersubForCV::Install::Files)
      1 perl-B-Hooks-OP-Check-EntersubForCV-devel = 0.09-13.fc25
      1 perl-B-Hooks-OP-Check-EntersubForCV-devel(x86-64) = 0.09-13.fc25
Binary provides are Ok.

$ rpmlint ./perl-B-Hooks-OP-Check-EntersubForCV*
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error Summary(en_US) entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error %description -l en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error Summary(en_US) entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error %description -l en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: only-non-binary-in-usr-lib
perl-B-Hooks-OP-Check-EntersubForCV-devel.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 6 warnings.

Rpmlint is ok

BuildRequires
FIX: Please add BRs
 * coreutils - spec file line 54
 * perl(Module::Install::Makefile) - define makemaker_args used in Makefile.PL (line 27)

Please correct all 'FIX' issues

Otherwise the package looks good.
Approved.
Comment 3 Petr Pisar 2016-03-29 13:08:02 UTC 
Waiting for unretiring the package <https://fedorahosted.org/rel-eng/ticket/6381>.
Comment 4 Petr Pisar 2016-04-11 07:49:24 UTC 
Thank you for the review and the repository. I fixed the two issues.
Comment 5 Fedora Update System 2016-04-11 07:53:10 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-82654c073a
Comment 6 Fedora Update System 2016-04-11 08:03:15 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6983367fe8
Comment 7 Fedora Update System 2016-04-11 10:19:06 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-82654c073a
Comment 8 Fedora Update System 2016-04-13 09:28:55 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6983367fe8
Comment 9 Fedora Update System 2016-04-15 03:18:29 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2016-04-20 19:21:56 UTC 
perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.